Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call SetDirty method on the back place of full-width characters. #251

Merged

Conversation

otani-koji
Copy link
Contributor

@otani-koji otani-koji commented Jan 8, 2019

This Pull-Request is a modification of this issue: #250

When content is full-width character, this following width is 2.
https://github.com/gdamore/tcell/blob/master/console_win.go#L758

But, SetDirty method is called only at the beginning.
So, I have modified it to call SetDirty method at the back place of full-width characters.

@otani-koji otani-koji closed this Jan 8, 2019
@otani-koji otani-koji deleted the set_dirty_for_full_width_characters branch January 8, 2019 10:02
@otani-koji otani-koji restored the set_dirty_for_full_width_characters branch January 8, 2019 10:03
@otani-koji otani-koji reopened this Jan 8, 2019
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #251   +/-   ##
======================================
  Coverage    19.7%   19.7%           
======================================
  Files          17      17           
  Lines        1441    1441           
======================================
  Hits          284     284           
  Misses       1140    1140           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaadc57...f83036c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #251 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #251   +/-   ##
======================================
  Coverage    19.7%   19.7%           
======================================
  Files          17      17           
  Lines        1441    1441           
======================================
  Hits          284     284           
  Misses       1140    1140           
  Partials       17      17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaadc57...f83036c. Read the comment docs.

@gdamore
Copy link
Owner

gdamore commented Mar 11, 2019

Does this resolve #250 ?

If so, can you change the commit comment to:

'fixes #250 Some characters disappear on Windows'

Thanks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants