This repository has been archived by the owner on Oct 16, 2023. It is now read-only.
gh-969: Remove use of code deprecated in Gaffer #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t92549
reviewed
Feb 17, 2022
| LOGGER.info("Using test properties of {}", testProperties); | ||
| final Graph graph = new Graph.Builder() | ||
| .graphId(testProperties.getGraphId()) | ||
| .config(new GraphConfig(testProperties.getGraphId())) |
There was a problem hiding this comment.
It MAY be better to use the GraphConfig Builder as it may set some defaults
There was a problem hiding this comment.
Seems fine to me. I can't see any downside so long as those defaults don't change the overall behaviour.
Codecov Report
@@ Coverage Diff @@
## v2-alpha #970 +/- ##
===========================================
Coverage ? 50.15%
Complexity ? 125
===========================================
Files ? 42
Lines ? 1607
Branches ? 130
===========================================
Hits ? 806
Misses ? 747
Partials ? 54 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue