This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
Component doesn't updates on path change
#388
Comments
|
@gbiryukov thanks for the detailed bug report, would you like to send a PR? |
|
sure, np |
gbiryukov
added a commit
to gbiryukov/tcomb-form
that referenced
this issue
Jun 14, 2017
gcanti
pushed a commit
that referenced
this issue
Jun 16, 2017
* add update on path change test * respect path changes in Component `shouldComponentUpdate` method (#388) * add `isArraysDiffers` util * compare path array by value instead of reference * rename `isArraysDiffers` -> `isArraysShallowDiffers`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version
Expected behaviour
Components gets re-rendered when its path changes.
Actual behaviour
tcomb
Componentclass hasshouldComponentUpdatedefined that prevent component update onpathchangesSteps to reproduce
You will see that remaining element will have path
1.titlebut it's actual path0.title.If you will try to type something into this textbox it will pass incorrect path to form
onChangecallbackIt quite easy to fix in
t.form.ComponentshouldComponentUpdatemethodThe text was updated successfully, but these errors were encountered: