Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

Radio component does not have a transformer #226

Closed
tamagokun opened this issue Oct 6, 2015 · 5 comments
Closed

Radio component does not have a transformer #226

tamagokun opened this issue Oct 6, 2015 · 5 comments

Comments

@tamagokun
Copy link

This only appears to be an issue in IE10 through some cross-browser testing i've been doing.

I can't mount a Radio button field as the Component's getTransformer method returns undefined.

I believe adding a transformer to the Radio class would fix this.

@tamagokun
Copy link
Author

Under further investigation:

It appears that IE10 is unable to see the default transformer that is in Component. Class inheritance must not be working right.

@tamagokun
Copy link
Author

https://babeljs.io/docs/advanced/caveats/

IE10 does not support __proto__ that would make sense. I'm not sure if you want to achieve IE10 support or not, feel free to just close this issue out.

@gcanti
Copy link
Owner

gcanti commented Oct 7, 2015

Hi!
Thanks for digging into this. From what I understand there are two solutions:

  1. adding the default static transformer to the Radio component
  2. using the optional spec.protoToAssign babel transformer https://babeljs.io/docs/advanced/transformers/spec/proto-to-assign

I'd go for 1), what do you think?

@tamagokun
Copy link
Author

I'd prefer 1. It's cleaner that way I think.

@gcanti
Copy link
Owner

gcanti commented Oct 12, 2015

Released in v0.6.8 and v0.7.4

@gcanti gcanti closed this as completed Oct 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants