Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lookup Table PSF #84

Merged
merged 65 commits into from
Jan 15, 2025
Merged

Update Lookup Table PSF #84

merged 65 commits into from
Jan 15, 2025

Conversation

gbrammer
Copy link
Owner

Enable fitting for shifts of each individual trace and then re-derive lookup table PSF files.

The files were generated with the notebooks at https://github.com/gbrammer/msaexp-calibration.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 37.17472% with 338 lines in your changes missing coverage. Please review.

Project coverage is 50.82%. Comparing base (ba717fa) to head (4614b80).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
msaexp/utils.py 19.19% 240 Missing ⚠️
msaexp/spectrum.py 56.14% 50 Missing ⚠️
msaexp/slit_combine.py 61.90% 48 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #84       +/-   ##
===========================================
- Coverage   65.75%   50.82%   -14.94%     
===========================================
  Files          16       16               
  Lines        7437     7908      +471     
===========================================
- Hits         4890     4019      -871     
- Misses       2547     3889     +1342     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbrammer gbrammer merged commit 5039357 into main Jan 15, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant