Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't drag multiple items due to automatic deselection #65

Open
Metalfusion opened this issue Dec 13, 2022 · 2 comments
Open

Can't drag multiple items due to automatic deselection #65

Metalfusion opened this issue Dec 13, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@Metalfusion
Copy link

Repro steps:

  1. Have at least 2 classes in a C# class diagram.
  2. Select both classes with marquee or shift-click.
  3. Click and drag from one of the selected classes.

Expectation: Both classes remain selected and get dragged around.
Reality: The second class gets deselected and only the one where dragging started gets moved.

This can be worked around by holding shift when starting drag on unselected item, but this is quite cumbersome.
I believe this is a regression from original NClass.

@gbaychev
Copy link
Owner

Thank you for reporting this, it could be that it is a regression. I'm going to check it after the holidays.

@gbaychev gbaychev self-assigned this Dec 18, 2022
@gbaychev gbaychev added the Bug label Dec 18, 2022
gbaychev added a commit that referenced this issue Jun 20, 2023
 This also allows to deselect/select when doing multiple elements
 selection holding ctrl/shift.

 The problem is that, if you have two selected elements and if you click
 one of them, it won't clear the selection. But this is the same
 behaviour as the original NClass
@gbaychev
Copy link
Owner

gbaychev commented Jun 20, 2023

So, it is indeed a regression from the original version. I broke it when I tried to implement the usual 'add/remove to/from selection when holding ctrl and/or shift' logic, which you can find in the most desktop apps today.

The ctrl/shift thing should work now, the only caveat is, that if you have multiple elements selecting, click one of them won't remove the rest from the selection (if they get removed, then the regression happens). But this is also the behavior in the original NClass.

@gbaychev gbaychev added this to the v2.8.4 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants