copy transition state to prevent concurrency issue #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
reviewed
Feb 20, 2024
| } | ||
|
|
||
| func (db *cachingDB) SetActiveTransitionState(ts *TransitionState) { | ||
| db.CurrentTransitionState = ts |
There was a problem hiding this comment.
Shouldn't we use a lock here?
Despite you tried making the assignment "more atomic" now (all fields at once), this still can have a race.
gballet
force-pushed
the
store-transition-state-in-db
branch
from
0211702 to
bb933ec
Compare
|
The giant lock approach works well enough, this would be considered an optimization. It doesn't make sense to work on it right now as many more changes are going to come in. I'll start again from scratch when needed. Adding a tag and closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.