Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol checking test when compiled with debug symbols (backport #1474) #1475

Merged
merged 1 commit into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. Fix symbol checking test when compiled with debug symbols (#1474)

    * Fix symbol checking test
    
    The test that checks for prefixed binary symbols was broken when
    compiled with DebWithRelInfo since it was checking debugging symbols
    that broke the heuristics used.
    
    The commit fixes it doing a couple of actions:
     - Include the length of the namespace sdf: 3sdf
     - Check only dynamic symbols being exported
    
    Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
    
    * Update test/integration/all_symbols_have_version.bash.in
    
    Co-authored-by: Steve Peters <scpeters@openrobotics.org>
    Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
    
    ---------
    
    Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
    Co-authored-by: Steve Peters <scpeters@openrobotics.org>
    (cherry picked from commit 904706c)
    j-rivero authored and mergify[bot] committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ae32d3a View commit details
    Browse the repository at this point in the history