Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty strings in plugin and custom attributes #1407

Merged
merged 4 commits into from
May 20, 2024
Merged

Allow empty strings in plugin and custom attributes #1407

merged 4 commits into from
May 20, 2024

Commits on Apr 30, 2024

  1. Add empty attributes to cause test failure 

    This demonstrates the bug reported in #725.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    @scpeters
    scpeters committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0637c21 View commit details
    Browse the repository at this point in the history

  2. Allow attributes to be empty 

    This allows custom attributes and unrecognized
attributes to contain empty strings by setting
required == 0 when calling Element::AddAttribute.

Fixes #725.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    @scpeters
    scpeters committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e55a9e1 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Element::ToString: print empty custom attributes 

    Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    @scpeters
    scpeters committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a4f811f View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Merge branch 'sdf14' into scpeters/allow_empty_custom_attributes

    @scpeters
    scpeters authored May 20, 2024
    Configuration menu
    Copy the full SHA
    39036ee View commit details
    Browse the repository at this point in the history