Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior of Param::Get<bool> #1397

Merged
merged 4 commits into from
Apr 10, 2024

Commits on Apr 9, 2024

  1. Change behavior of Param::Get<bool>

    Previously when a Param was set from a string, the
    `Get<bool>` method would always return `true`, and
    the value would be `true` if the lowercase value string
    matched `"1"` or `"true"`. Otherwise the value would
    be `false`.
    
    Now, the `Get<bool>` method returns `true` only if the
    lowercase value string matches one of `"0"`, `"1"`,
    `"true"`, or `"false"`. Otherwise `Get<bool>` returns
    `false` and the value is not written.
    
    Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    scpeters committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7442a7d View commit details
    Browse the repository at this point in the history
  2. pyParam_TEST.py: update comment

    Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    scpeters authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    6d348c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Fix comment

    Signed-off-by: Steve Peters <scpeters@openrobotics.org>
    scpeters committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    597964a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7a1f68 View commit details
    Browse the repository at this point in the history