SDF.cc update calls to use sdf::Errors output #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 9, 2023 15:17
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
|
This PR depends on #1294 for the tests to pass since they check nothing is printed. |
|
This function signature was kept (even though is not public) because otherwise it would involve further changes in |
azeey
removed
🎵 harmonic
scpeters
reviewed
Jun 24, 2024
include/sdf/Error.hh
Outdated
| @@ -179,6 +179,9 @@ namespace sdf | |||
|
|
|||
| /// \brief Generic error during parsing. | |||
| PARSING_ERROR, | |||
|
|
|||
| /// \brief File not found error. | |||
| FILE_NOT_FOUND, | |||
There was a problem hiding this comment.
a review thread in #1296 (comment) recommends using FILE_READ instead of adding a new enum for this
There was a problem hiding this comment.
I've opened #1442 targeting this branch to use FILE_READ instead of a new enum
This was referenced Jun 24, 2024
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
reviewed
Jun 26, 2024
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Work towards #820.
Summary
Adds missing
sdf::Errorsstructure as an option to report errors onSDF. Makes sure that no errors are printed and all are reported through the structure when using the functions that include it as parameter.Test it
Call the functions that report
sdf::Errorsthrough a parameter and no errors should be printed but only reported through the sdf structure.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.