Frame: update calls to use sdf::Errors output #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoag
changed the title
added 2 commits
October 3, 2022 16:32
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
marcoag
force-pushed
the
marcoag/sdf_error_frame
branch
from
d2b787a
to
1ae2f41
Compare
Codecov Report
@@ Coverage Diff @@
## sdf13 #1156 +/- ##
=======================================
Coverage 87.50% 87.50%
=======================================
Files 126 126
Lines 16408 16413 +5
=======================================
+ Hits 14358 14363 +5
Misses 2050 2050
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
aaronchongth
requested changes
Mar 28, 2023
src/Frame.cc
Outdated
| @@ -219,25 +219,34 @@ sdf::ElementPtr Frame::Element() const | |||
| return this->dataPtr->sdf; | |||
| } | |||
|
|
|||
| ///////////////////////////////////////////////// | |||
| /////////////////////////////////////////////// | |||
There was a problem hiding this comment.
probably accidentally removed 2 characters here
There was a problem hiding this comment.
True, maybe I'm going too fast over these changes hehe. Thanks for the catch, should be fixed now.
added 2 commits
March 28, 2023 04:06
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
marcoag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco A. Gutierrez marco@openrobotics.org
🎉 New feature
Work towards #820.
Depends on: #1141.
Summary
Adds missing
Errorsstructure parameters in a few methods of theFrameclass.Test it
Using the
Frameclass should report all errors throughsdf::Errorsif theerrorsparameter is used, it should print them otherwise.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.