-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry and others: update calls to use sdf::Errors parameters #1153
Conversation
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
46c2718
to
daf5695
Compare
Codecov Report
@@ Coverage Diff @@
## sdf13 #1153 +/- ##
==========================================
+ Coverage 87.66% 87.72% +0.05%
==========================================
Files 126 126
Lines 16506 16585 +79
==========================================
+ Hits 14470 14549 +79
Misses 2036 2036
|
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
When I thought I was almost done adding the I guess we should keep this PR on hold until that one is merged and ported to |
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Can you fix the conflicts? |
…b.com/gazebosim/sdformat into marcoag/sdf_error_geometry_and_others
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
The test failures on windows are being investigated in #1276. |
Signed-off-by: Marco A. Gutierrez marco@openrobotics.org
🎉 New feature
Work towards #820.
Depends on: #1141.
Depends on: #1263 and its forward port.
Summary
Adds missing
Errors
structure parameters in a few methods of the following classes:Adding several classes updates on this PR due to inter dependencies.
Test it
Using the classes above should report all errors through
sdf::Errors
if theerrors
parameter is used, it should print them otherwise.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.