Noise: update calls to use sdf::Errors parameters

[marcoag]

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Depends on: #1141.

Summary

Adds missing Errors structure parameters in a few methods of the Noise class.

Test it

Using the Noise class should report all errors through sdf::Errors if the errors parameter is used, it should print them otherwise.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[aaronchongth]

LGTM!

[aaronchongth]

Just noticed that there is Noise_TEST.cc, could you a few minimal tests for the function overload? Perhaps something similar to TEST(DOMNoise, ToElement), and another where an expected error is returned

[aaronchongth]

Per DM, changes are small enough, more tests not required. LGTM!

[codecov]

Codecov Report

Merging #1151 (2b32fcc) into sdf13 (9d83fe5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2b32fcc differs from pull request most recent head d5c657f. Consider uploading reports for the commit d5c657f to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1151   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files         126      126           
  Lines       16341    16349    +8     
=======================================
+ Hits        14289    14297    +8     
  Misses       2052     2052           

Impacted Files	Coverage Δ
src/Noise.cc	96.09% <100.00%> (+0.26%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[marcoag]

Per DM, changes are small enough, more tests not required. LGTM!

Just went ahead and added a test, since the workload was not very heavy.

[aaronchongth]

Thanks for adding the test!