Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: update calls to use sdf::Errors output #1144

Merged
merged 6 commits into from
Mar 24, 2023
Merged

Conversation

marcoag
Copy link
Member

@marcoag marcoag commented Sep 16, 2022

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

🎉 New feature

Work towards #820.

Depends on: #1141.

Summary

Adds missing Errors structure parameters in a few methods of the Plugin class.

Test it

Using the Plugin class should report all errors through sdf::Errors if the errors parameter is used, it should print them otherwise.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1144 (0831fbd) into sdf13 (131750f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 0831fbd differs from pull request most recent head 8c3b313. Consider uploading reports for the commit 8c3b313 to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1144      +/-   ##
==========================================
+ Coverage   87.42%   87.44%   +0.02%     
==========================================
  Files         126      126              
  Lines       16314    16341      +27     
==========================================
+ Hits        14262    14289      +27     
  Misses       2052     2052              
Impacted Files Coverage Δ
include/sdf/Plugin.hh 93.75% <ø> (ø)
src/Plugin.cc 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Marco A. Gutierrez added 3 commits October 3, 2022 10:37
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag changed the base branch from main to sdf13 October 3, 2022 10:38
Marco A. Gutierrez added 2 commits March 22, 2023 10:49
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
include/sdf/Plugin.hh Outdated Show resolved Hide resolved
include/sdf/Plugin.hh Outdated Show resolved Hide resolved
Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
@marcoag marcoag changed the title Plugin: add sdf::Errors output to API methods Plugin: update calls to use sdf::Errors output Mar 24, 2023
@marcoag marcoag merged commit 9d83fe5 into sdf13 Mar 24, 2023
@marcoag marcoag deleted the marcoag/sdf_error_plugin branch March 24, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants