Skip to content

Commit

Permalink
Suggestions for #939
Browse files Browse the repository at this point in the history 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
  • Loading branch information
@azeey
azeey committed May 5, 2022
1 parent 4ea168c commit 9919dc9
Showing 1 changed file with 62 additions and 46 deletions.
108 changes: 62 additions & 46 deletions test/integration/error_output.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,97 +36,113 @@ TEST(Error, ErrorOutput)

sdf::Errors errors;
ASSERT_NO_THROW(sdf::Param param1("key", "not_valid_type", "true", false,
errors, "description"));
ASSERT_EQ(errors[0].Code(), sdf::ErrorCode::UNKNOWN_PARAMETER_TYPE);
ASSERT_NE(std::string::npos,
errors[0].Message().find(
"Unknown parameter type[not_valid_type]"));
ASSERT_EQ(errors[1].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos,
errors[1].Message().find("Invalid parameter"));
errors, "description"));
ASSERT_GE(2u, errors.size());
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::UNKNOWN_PARAMETER_TYPE);
EXPECT_NE(std::string::npos,
errors[0].Message().find(
"Unknown parameter type[not_valid_type]"));
EXPECT_EQ(errors[1].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos,
errors[1].Message().find("Invalid parameter"));

errors.clear();
ASSERT_NO_THROW(sdf::Param param2("key", "not_valid_type", "true",
false, "", "", errors, "description"));
ASSERT_EQ(errors[2].Code(), sdf::ErrorCode::UNKNOWN_PARAMETER_TYPE);
ASSERT_NE(std::string::npos,
errors[2].Message().find("Unknown parameter type[not_valid_type]"));
ASSERT_EQ(errors[3].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos,
errors[3].Message().find("Invalid parameter"));
ASSERT_GE(2u, errors.size());
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::UNKNOWN_PARAMETER_TYPE);
EXPECT_NE(std::string::npos,
errors[0].Message().find("Unknown parameter type[not_valid_type]"));
EXPECT_EQ(errors[1].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos,
errors[1].Message().find("Invalid parameter"));

errors.clear();
sdf::Param param3("key", "bool", "true", false, errors, "description");
// Check no new errors were added
ASSERT_EQ(errors.size(), 4u);
ASSERT_EQ(errors.size(), 0u);
param3.Set(4, errors);
ASSERT_EQ(errors[4].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos,
errors[4].Message().find("Invalid boolean value"));
ASSERT_GE(errors.size(), 1u);
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos,
errors[0].Message().find("Invalid boolean value"));

errors.clear();
ignition::math::Pose3d pose;
param3.Get<ignition::math::Pose3d>(pose, errors);
ASSERT_EQ(errors[5].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[5].Message().find(
ASSERT_GE(errors.size(), 1u);
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[0].Message().find(
"The value for //pose[@rotation_format='euler_rpy'] must have 6 "
"values, but 1 were found instead in '1'."));

errors.clear();
param3.Update(errors);
ASSERT_EQ(errors[6].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[6].Message().find(
ASSERT_GE(errors.size(), 1u);
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[0].Message().find(
"[updateFunc] is not set."));

errors.clear();
sdf::Param requiredParam("key", "int", "1", true, "2", "4", errors,
"description");
// Check no new errors were added
ASSERT_EQ(errors.size(), 7u);
ASSERT_EQ(errors.size(), 0u);
requiredParam.SetFromString("", errors);
ASSERT_EQ(errors[7].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[7].Message().find(
ASSERT_GE(errors.size(), 1u);
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[0].Message().find(
"Empty string used when setting a required parameter. Key[key]"));
ASSERT_FALSE(requiredParam.ValidateValue(errors));
ASSERT_EQ(errors[8].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[8].Message().find(
EXPECT_FALSE(requiredParam.ValidateValue(errors));
ASSERT_GE(errors.size(), 2u);
EXPECT_EQ(errors[1].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[1].Message().find(
"The value [1] is less than the minimum allowed value of [2] for "
"key [key]"));


errors.clear();
// Adding a parent with @rotation_format to something invalid
// will make reparse fail
sdf::Param poseParam("", "pose", "1 2 3 0.4 0.5 0.6", false, "description");
sdf::ElementPtr poseElem(new sdf::Element);
poseElem->AddAttribute("rotation_format", "string", "invalid_format", false);
ASSERT_FALSE(poseParam.SetParentElement(poseElem, errors));
ASSERT_EQ(errors[9].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[9].Message().find(
EXPECT_FALSE(poseParam.SetParentElement(poseElem, errors));
ASSERT_EQ(errors.size(), 2u);
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[0].Message().find(
"Undefined attribute //pose[@rotation_format='invalid_format'], "
"only 'euler_rpy' and 'quat_xyzw' is supported."));
ASSERT_EQ(errors[10].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[10].Message().find(
EXPECT_EQ(errors[1].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[1].Message().find(
"Failed to set value '1 2 3 0.40000000000000002 0.5 "
"0.59999999999999987' to key [] for new parent element of name '',"
" reverting to previous value '1 2 3 0.40000000000000002 0.5 "
"0.59999999999999987'."));

errors.clear();
sdf::Param param4("key", "bool", "15", false, "a", "b", errors,
"description");
ASSERT_EQ(errors[11].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[11].Message().find(
ASSERT_EQ(errors.size(), 6u);
EXPECT_EQ(errors[0].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[0].Message().find(
"Invalid boolean value"));
ASSERT_EQ(errors[12].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[12].Message().find(
EXPECT_EQ(errors[1].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[1].Message().find(
"Invalid parameter"));
ASSERT_EQ(errors[13].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[13].Message().find(
EXPECT_EQ(errors[2].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[2].Message().find(
"Invalid boolean value"));
ASSERT_EQ(errors[14].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[14].Message().find(
EXPECT_EQ(errors[3].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[3].Message().find(
"Invalid [min] parameter in SDFormat description of [key]"));
ASSERT_EQ(errors[15].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[15].Message().find(
EXPECT_EQ(errors[4].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[4].Message().find(
"Invalid boolean value"));
ASSERT_EQ(errors[16].Code(), sdf::ErrorCode::PARAMETER_ERROR);
ASSERT_NE(std::string::npos, errors[16].Message().find(
EXPECT_EQ(errors[5].Code(), sdf::ErrorCode::PARAMETER_ERROR);
EXPECT_NE(std::string::npos, errors[5].Message().find(
"Invalid [max] parameter in SDFormat description of [key]"));

// Check nothing has been printed
ASSERT_TRUE(buffer.str().empty()) << buffer.str();
EXPECT_TRUE(buffer.str().empty()) << buffer.str();
}

0 comments on commit 9919dc9

Please sign in to comment.