Eliminates std::filesystem usage in utils.cc #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on gazebosim/gz-common#312 See gazebo-tooling/release-tools#639 Basically, this removes the dependency on `std::filesystem` in ign-gazebo as its been causing issues when binaries are produced by diffrent compiler versions. This current version makes sure that we keep all `std::filesystem` code in` ign-common`. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
nkoenig
approved these changes
Feb 16, 2022
|
I think you can target this to ign-gazebo6, and the same goes for the ign-common PR. |
mjcarroll
added
the
needs upstream release
|
I guess we are going to have to do an |
|
@osrf-jenkins run tests again
This is targeting unstable branches, so we should be able to use the nightlies |
chapulina
removed
the
needs upstream release
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Depends on gazebosim/gz-common#312
See gazebo-tooling/release-tools#639
Basically, this removes the dependency on
std::filesystemin ign-gazebo as its been causing issues when binaries are produced by different compiler versions. This current version makes sure that we keep allstd::filesystemcode inign-common.Signed-off-by: Arjo Chakravarty arjo@openrobotics.org
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.