Add proto message for MaterialColor. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proto message allows for changing the material colors of an entities visual. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
This was referenced Jan 14, 2024
ahcorde
requested changes
Jan 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-msgs10 #414 +/- ##
==========================================
Coverage 97.67% 97.67%
==========================================
Files 27 27
Lines 1163 1163
==========================================
Hits 1136 1136
Misses 27 27 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
bperseghetti
force-pushed
the
pr-material_color
branch
from
4e3bfb2
to
5c03d8a
Compare
ahcorde
approved these changes
Jan 15, 2024
azeey
reviewed
Jan 16, 2024
bperseghetti
added a commit
to rudislabs/gz-msgs
that referenced
this pull request
Mar 27, 2024
* Add proto message for MaterialColor. This proto message allows for changing the material colors of an entities visual. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
The MateriaColor proto message allows for changing the material colors of an entities visual component easily and can even be done from ROS using the gz bridge.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.