Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Image Display to use ConvertToRGB function #212

Merged
merged 4 commits into from
May 10, 2021
Merged

Refactor Image Display to use ConvertToRGB function #212

merged 4 commits into from
May 10, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 23, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

🎉 New feature

Summary

Depends on gazebosim/gz-common#205

Updated Image Display to use the new Image::ConvertToRGB function for visualizing depth and thermal camera sensor images, see gazebosim/gz-common#205

Test it

Run the sensors_demo.sdf world and you should see that the images in the the Image Display should be correctly rendered the same way as before.

ign gazebo -v 4 sensors_demo.sdf

sensors_demo_image_display

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@iche033
refactor image display to use convert to rgb function from ign common
d80019c 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from chapulina as a code owner April 23, 2021 21:02
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Apr 23, 2021
@iche033 iche033 mentioned this pull request Apr 23, 2021
Merged
8 tasks
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Apr 23, 2021
@adlarkin
Copy link
Contributor

adlarkin commented May 5, 2021

Would this by chance close #177?

@iche033
Copy link
Contributor Author

iche033 commented May 5, 2021

Would this by chance close #177?

ah forgot about that one - yes it'll close the issue

@adlarkin adlarkin linked an issue May 5, 2021 that may be closed by this pull request
Merge Image Display UpdateFrom* functions. #177
Closed
jennuine
jennuine reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And works as described. A few minor comments

src/plugins/image_display/ImageDisplay.cc Show resolved Hide resolved
src/plugins/image_display/ImageDisplay.cc Outdated Show resolved Hide resolved
@iche033
remove functions from header
25eaf0c 
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
jennuine
jennuine approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chapulina
Depend on ign-common3.13
04ce9fd 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

Bumped the required ign-common version in 04ce9fd

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 7, 2021
@mjcarroll
Copy link
Contributor

This should be unblocked from the ign-common release now

@chapulina chapulina merged commit 1fd25de into ign-gui4 May 10, 2021
@chapulina chapulina deleted the image_display_refactor branch May 10, 2021 17:17
@adlarkin adlarkin mentioned this pull request Jul 6, 2021
Closed
@peci1 peci1 mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine jennuine approved these changes

@chapulina chapulina Awaiting requested review from chapulina

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge Image Display UpdateFrom* functions.
5 participants
@iche033 @adlarkin @chapulina @mjcarroll @jennuine