add missing includes #660
Merged
add missing includes #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix:
```cpp
/build/source/test/performance/logging.cc: In function 'void {anonymous}::PrintStats(const std::string&, const std::map<long unsigned int, std::vector<long unsigned int> >&, uint64_t)':
/build/source/test/performance/logging.cc:79:16: error: 'max_element' is not a member of 'std'; did you mean 'tuple_element'?
79 | (*std::max_element(t_result.second.begin(), t_result.second.end()));
| ^~~~~~~~~~~
```
Signed-off-by: Guilhem Saurel <guilhem.saurel@laas.fr>
to fix:
```cpp
In file included from /build/source/testing/include/gz/common/testing/AutoLogFixture.hh:58,
from /build/source/src/MaterialDensity_TEST.cc:20:
/build/source/testing/include/gz/common/testing/detail/AutoLogFixture.hh: In member function 'virtual void gz::common::testing::AutoLogFixture::SetUp()':
/build/source/testing/include/gz/common/testing/detail/AutoLogFixture.hh:79:8: error: 'replace' is not a member of 'std'
79 | std::replace(this->dataPtr->logFilename.begin(),
| ^~~~~~~
```
Signed-off-by: Guilhem Saurel <guilhem.saurel@laas.fr>
ahcorde
approved these changes
Jan 20, 2025
|
@ros-pull-request-builder retest this please |
mjcarroll
approved these changes
Jan 21, 2025
|
@osrf-jenkins retest this please |
iche033
approved these changes
Jan 21, 2025
|
Windows failure tracked in #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi,
This fix a couple of missing includes:
and
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.