Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header was dropped in the forward port and breaks downstream #515

Merged
merged 1 commit into from
May 22, 2023

Conversation

mjcarroll
Copy link
Contributor

No description provided.

Some other libraries (notably fuel tools) are dependent on the
transitive include.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll requested a review from marcoag as a code owner May 22, 2023 18:59
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #515 (9674e53) into gz-common5 (f96e361) will not change coverage.
The diff coverage is n/a.

❗ Current head 9674e53 differs from pull request most recent head 4ed7f91. Consider uploading reports for the commit 4ed7f91 to get more accurate results

@@             Coverage Diff             @@
##           gz-common5     #515   +/-   ##
===========================================
  Coverage       83.65%   83.65%           
===========================================
  Files              90       90           
  Lines           10249    10249           
===========================================
  Hits             8574     8574           
  Misses           1675     1675           

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem I was having building Gazebo Garden from source. Thanks @mjcarroll !

@mjcarroll mjcarroll merged commit 466f83f into gz-common5 May 22, 2023
@mjcarroll mjcarroll deleted the mjcarroll/fix_dropped_header branch May 22, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants