Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile tutorial #487

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 4, 2023

Signed-off-by: Nate Koenig nate@openrobotics.org

🦟 Bug fix

This tutorial was rendering improperly, see here.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from mjcarroll as a code owner February 4, 2023 00:39
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 4, 2023
@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Merging #487 (d439394) into gz-common5 (f62bbb0) will not change coverage.
The diff coverage is n/a.

❗ Current head d439394 differs from pull request most recent head 1799567. Consider uploading reports for the commit 1799567 to get more accurate results

@@             Coverage Diff             @@
##           gz-common5     #487   +/-   ##
===========================================
  Coverage       80.59%   80.59%           
===========================================
  Files              90       90           
  Lines           10242    10242           
===========================================
  Hits             8255     8255           
  Misses           1987     1987           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll
Copy link
Contributor

Why... does this increase code coverage? 😕

@mjcarroll mjcarroll merged commit 0721217 into gz-common5 Feb 4, 2023
@mjcarroll mjcarroll deleted the fix_profile_tutorial_rendering branch February 4, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants