Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Capsule mesh generation #475

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Nov 2, 2022

🦟 Bug fix

Fixes gazebosim/gz-sim#1769

Summary

In #186 Capsule was updated to be z-up, however when merging forward the ign-gz changes, the logic was accidentally reverted.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mjcarroll as a code owner November 2, 2022 19:00
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #475 (b8e5b12) into ign-common4 (ade3fa2) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           ign-common4     #475   +/-   ##
============================================
  Coverage        78.92%   78.92%           
============================================
  Files               75       75           
  Lines             9556     9556           
============================================
  Hits              7542     7542           
  Misses            2014     2014           
Impacted Files Coverage Δ
graphics/src/MeshManager.cc 86.62% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants