Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo bug in MaterialIndex #338

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 7, 2022

🦟 Bug fix

Summary

A typo in the following snippet was causing materialIndex to be accessed when did not contain a value.

if (this-dataPtr->materialIndex.has_value()) //  Note the `-` instead of `->` in `this-dataPtr`.
    return this->dataPtr->materialIndex.value();

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey added 2 commits April 7, 2022 14:07
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from mjcarroll as a code owner April 7, 2022 19:14
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #338 (e955fec) into main (2a26202) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   77.10%   77.14%   +0.03%     
==========================================
  Files          76       76              
  Lines       10548    10547       -1     
==========================================
+ Hits         8133     8136       +3     
+ Misses       2415     2411       -4     
Impacted Files Coverage Δ
graphics/src/SubMesh.cc 91.08% <100.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a26202...e955fec. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch!

@chapulina chapulina merged commit 8761b6f into gazebosim:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants