Use direct evaluation for SKIP_av. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hill Ma <hillma@google.com>
github-actions
bot
added
🏢 edifice
Codecov Report
@@ Coverage Diff @@
## ign-common3 #250 +/- ##
===============================================
+ Coverage 76.55% 77.00% +0.45%
===============================================
Files 73 75 +2
Lines 10386 10655 +269
===============================================
+ Hits 7951 8205 +254
- Misses 2435 2450 +15
Continue to review full report at Codecov.
|
mjcarroll
approved these changes
Sep 27, 2021
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${}gives the result in string so something likecolcon build --merge-install --packages-up-to ignition-common4 --cmake-args '-DSKIP_av=true'might not work as expected.