Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ign-utils from TempDirectory #248

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Remove ign-utils from TempDirectory #248

merged 1 commit into from
Sep 15, 2021

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Fixes gazebo-tooling/gazebodistro#45

Summary

TempDirectory incorrectly added the ign-utils1 dependency, this roills that back.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Sep 15, 2021
@chapulina chapulina added beta Targeting beta release of upcoming collection bug Something isn't working labels Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #248 (53f6549) into ign-common4 (d06ed33) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 53f6549 differs from pull request most recent head 296ca2d. Consider uploading reports for the commit 296ca2d to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common4     #248   +/-   ##
============================================
  Coverage        77.00%   77.00%           
============================================
  Files               75       75           
  Lines            10655    10655           
============================================
  Hits              8205     8205           
  Misses            2450     2450           
Impacted Files Coverage Δ
src/TempDirectory.cc 78.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06ed33...296ca2d. Read the comment docs.

@mjcarroll mjcarroll merged commit bc7802d into ign-common4 Sep 15, 2021
@mjcarroll mjcarroll deleted the remove_utils branch September 15, 2021 20:26
@scpeters
Copy link
Member

sorry I'm late here. I know the ImplPtr handles copy and move constructors / assignment. I expect that isn't relevant to this class

@scpeters
Copy link
Member

sorry I'm late here. I know the ImplPtr handles copy and move constructors / assignment. I expect that isn't relevant to this class

should we explicitly delete those methods for this class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants