Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools/code_check and update codecov #219

Merged
merged 1 commit into from
May 13, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from mjcarroll as a code owner May 12, 2021 22:08
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 12, 2021
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #219 (0a11399) into ign-common3 (8f3b267) will increase coverage by 1.38%.
The diff coverage is 70.87%.

❗ Current head 0a11399 differs from pull request most recent head a45a6c3. Consider uploading reports for the commit a45a6c3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-common3     #219      +/-   ##
===============================================
+ Coverage        73.80%   75.18%   +1.38%     
===============================================
  Files               68       73       +5     
  Lines             9261    10326    +1065     
===============================================
+ Hits              6835     7764     +929     
- Misses            2426     2562     +136     
Impacted Files Coverage Δ
av/include/ignition/common/ffmpeg_inc.hh 0.00% <0.00%> (ø)
graphics/src/SVGLoader.cc 86.83% <ø> (ø)
include/ignition/common/Filesystem.hh 100.00% <ø> (ø)
include/ignition/common/Util.hh 100.00% <ø> (ø)
av/src/HWEncoder.cc 20.00% <20.00%> (ø)
graphics/src/SkeletonAnimation.cc 40.00% <35.71%> (-5.34%) ⬇️
graphics/src/Skeleton.cc 42.47% <44.44%> (-0.25%) ⬇️
graphics/src/Image.cc 67.08% <52.72%> (+6.97%) ⬆️
src/Filesystem.cc 76.11% <58.13%> (-3.33%) ⬇️
av/src/VideoEncoder.cc 76.25% <79.86%> (+27.92%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a7239...a45a6c3. Read the comment docs.

@mjcarroll mjcarroll merged commit 2e24122 into ign-common3 May 13, 2021
@mjcarroll mjcarroll deleted the chapulina/codecheck branch May 13, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants