Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ellipsoid indexes #159

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Fixed ellipsoid indexes #159

merged 2 commits into from
Jan 28, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jan 27, 2021

Fixed ellipsoid indexes, it was generating negative indexes.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the bug Something isn't working label Jan 27, 2021
@ahcorde ahcorde requested a review from mjcarroll January 27, 2021 11:19
@ahcorde ahcorde self-assigned this Jan 27, 2021
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #159 (c63829f) into ign-common3 (a8e59e1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #159   +/-   ##
============================================
  Coverage        75.87%   75.87%           
============================================
  Files               69       69           
  Lines             9758     9758           
============================================
  Hits              7404     7404           
  Misses            2354     2354           
Impacted Files Coverage Δ
graphics/src/MeshManager.cc 86.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e59e1...c63829f. Read the comment docs.

@nkoenig
Copy link
Contributor

nkoenig commented Jan 27, 2021

Is it possible to add a test?

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Jan 28, 2021

@nkoenig added the test c63829f

I can add the same test for the rest of the meshes in other PR

@ahcorde ahcorde merged commit f5550c0 into ign-common3 Jan 28, 2021
@ahcorde ahcorde deleted the ahcorde/fix/ellipsoid branch January 28, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint bug Something isn't working 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants