-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple texture coordinate sets #131
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
…common into multi_texcoord_set
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-common3 #131 +/- ##
===============================================
+ Coverage 75.38% 75.49% +0.11%
===============================================
Files 69 69
Lines 9494 9608 +114
===============================================
+ Hits 7157 7254 +97
- Misses 2337 2354 +17
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Lets get this in!
The SubMesh class have always supported only texture coordinate sets per submesh. This works for most cases but when it comes do adding lightmaps to meshes, they usually occupy a different texture coordinate set, i.e. they are mapped onto the mesh in a different way than the typical albedo and normal maps. This pull request adds new APIs that enable users to add texture coordinates for different sets in the same submesh. I've also updated the ColladaLoader to load multiple texture coordinate sets.