Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple texture coordinate sets #131

Merged
merged 21 commits into from
Dec 18, 2020
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Dec 1, 2020

The SubMesh class have always supported only texture coordinate sets per submesh. This works for most cases but when it comes do adding lightmaps to meshes, they usually occupy a different texture coordinate set, i.e. they are mapped onto the mesh in a different way than the typical albedo and normal maps. This pull request adds new APIs that enable users to add texture coordinates for different sets in the same submesh. I've also updated the ColladaLoader to load multiple texture coordinate sets.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from mjcarroll as a code owner December 1, 2020 01:26
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Dec 1, 2020
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina added the graphics Graphics component label Dec 1, 2020
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina mentioned this pull request Dec 8, 2020
graphics/src/ColladaLoader.cc Outdated Show resolved Hide resolved
graphics/src/ColladaLoader.cc Outdated Show resolved Hide resolved
graphics/src/ColladaLoader.cc Outdated Show resolved Hide resolved
graphics/src/ColladaLoader.cc Outdated Show resolved Hide resolved
graphics/src/SubMesh.cc Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #131 (1243429) into ign-common3 (3027dc0) will increase coverage by 0.11%.
The diff coverage is 89.61%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-common3     #131      +/-   ##
===============================================
+ Coverage        75.38%   75.49%   +0.11%     
===============================================
  Files               69       69              
  Lines             9494     9608     +114     
===============================================
+ Hits              7157     7254      +97     
- Misses            2337     2354      +17     
Impacted Files Coverage Δ
graphics/src/SubMesh.cc 91.31% <80.48%> (-4.14%) ⬇️
graphics/src/ColladaLoader.cc 85.17% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3027dc0...1243429. Read the comment docs.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Lets get this in!

@chapulina chapulina merged commit 5712a55 into ign-common3 Dec 18, 2020
@chapulina chapulina deleted the multi_texcoord_set branch December 18, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice graphics Graphics component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants