Video decoder fixes #114
Closed
Video decoder fixes #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🏢 edifice
…s on success. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
The previous approach stopped working because libavcodec now probably also examines other members of the packet than size and data. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
We definitely want to output an R8G8B8 image (I guess that's the only reason for the swscale to be there). Without this fix, the resulting image is a complete mess when interpreted as R8G8B8. Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
peci1
force-pushed
the
fix_video_decoder
branch
from
0ba90df to
8d1721a
Compare
|
I manually tested compatibility of this PR with #105 and it ran ok. |
|
I believe that you'll also need to update the branch with latest ign-common3 changes as well as do a DCO signoff. |
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
peci1
force-pushed
the
fix_video_decoder
branch
from
63ae6b5 to
ac496fd
Compare
|
Closing in favor of #125 which contains all of the fixes that were introduced in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few things regarding video decoding. Descriptions of the respective fixed problems is in the commit messages.
Basically, without this PR, decoding an MP4 video ends either with a segfault or nonsense output. I wonder if it ever worked for someone before.
The output pixel format fix assumes that the desired format of the output buffer is R8G8B8 (that was deduced from the swscale config). But as the docs were scarce here, I'm not sure whether it wasn't desired to output YUV420.
Finally, I added a test that checks a decode-encode-decode loop for basic functionality. It seems that up to FPS frames get lost at the end of the encoded video, but the same was observed in #110 and accepted, so I also accept it here.