Fixed parentPath() return when input has no parent (#307)

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

src/Filesystem.cc

@@ -209,6 +209,10 @@ std::string ignition::common::parentPath(const std::string &_path)
   // Maintain compatibility with ign-common
   if (*_path.rbegin() == fs::path::preferred_separator)
     p = fs::path(_path.substr(0, _path.size()-1));
+
+  if (!p.has_parent_path())
+    return _path;
+
   return p.parent_path().string();
 }
 

src/Filesystem_TEST.cc

@@ -473,6 +473,9 @@ TEST_F(FilesystemTest, parentPath)
   child_with_slash = separator(child_with_slash);
   std::string parent2 = parentPath(child_with_slash);
   EXPECT_EQ(parent, parent2);
+
+  std::string childOnly = "child";
+  EXPECT_EQ(childOnly, parentPath(childOnly));
 }
 
 /////////////////////////////////////////////////

src/Timer.cc

@@ -24,10 +24,10 @@ using namespace common;
 class ignition::common::Timer::Implementation
 {
   /// \brief The time of the last call to Start
-  public: std::chrono::steady_clock::time_point start; 
+  public: std::chrono::steady_clock::time_point start;
 
   /// \brief The time when Stop was called.
-  public: std::chrono::steady_clock::time_point stop; 
+  public: std::chrono::steady_clock::time_point stop;
 
   /// \brief True if the timer is running.
   public: bool running {false};
@@ -71,7 +71,7 @@ std::chrono::duration<double> Timer::ElapsedTime() const
   }
   else
   {
-    std::chrono::duration<double> diff = 
+    std::chrono::duration<double> diff =
       this->dataPtr->stop - this->dataPtr->start;
     return diff;
   }

src/Timer_TEST.cc

@@ -66,7 +66,7 @@ TEST(Timer_TEST, Copy)
   ignition::common::Timer t2 = t1;
   EXPECT_TRUE(t2.Running());
 
-  // Stop the original 
+  // Stop the original
   t1.Stop();
   EXPECT_FALSE(t1.Running());
   EXPECT_TRUE(t2.Running());

src/Util.cc

@@ -64,7 +64,7 @@
 /// destruction order fiasco issues.
 ignition::common::SystemPaths& GetSystemPaths()
 {
-  static 
+  static
     ignition::utils::NeverDestroyed<ignition::common::SystemPaths> paths;
   return paths.Access();
 }