Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

Wrong information in the tray icon when plugged in #45

Closed
Alian51 opened this issue Nov 8, 2020 · 7 comments
Closed

Wrong information in the tray icon when plugged in #45

Alian51 opened this issue Nov 8, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@Alian51
Copy link

Alian51 commented Nov 8, 2020

With mouse over the tray icon, the mention On Battery (xx%) is mentioned even if the UPS is on AC (at least in the French version, maybe only a translation mismatch).
The tray icon is well reacting when plugging / unplugging the UPS on / from AC, becoming green or red, but the indication still showing On Battery.
BTW, very good app!
Tray icon mouse over.docx

@gawindx
Copy link
Owner

gawindx commented Nov 9, 2020

this is not a bug in the sense that, even if your ups is plugged into the mains, your battery is not necessarily 100% charged (which is the case on your capture), especially after a power cut .

In addition, the fact of displaying the state of charge also makes it possible to see a battery problem coming, such as a battery which no longer takes the charge correctly or which does not maintain its nominal voltage (and therefore its charge).

@gawindx
Copy link
Owner

gawindx commented Nov 9, 2020

I read a little quickly (and badly because, like you, I am French).
indeed, this is not normal.
that the battery level is always displayed is normal, but that we are all the time on battery even connected to the mains is not.

has to be corrected for the next version (and it is indeed possible that this is a translation error).

@gawindx gawindx added the bug Something isn't working label Nov 9, 2020
@Alian51
Copy link
Author

Alian51 commented Nov 9, 2020

Thanks for your feedback ! And looking forward to installing the new version as soon as released!

@gawindx
Copy link
Owner

gawindx commented Jan 12, 2021

I come back to you concerning this problem (I am putting my hands in the code so I am taking advantage of it).

It seems that your problem is not due to a translation problem but rather to a bad treatment (of my fault therefore) of the return value of the state of your ups, value which seems to be returned with an unnecessary space (thus fault of your inverter or NUT server).

What is stupid is that I had bypassed the problem for the value of the icon but I did not think of doing it for the text ...

this will be fixed in v2.0.5 (should be released soon).

@Alian51
Copy link
Author

Alian51 commented Jan 13, 2021 via email

gawindx added a commit that referenced this issue Jan 18, 2021
Changed : Some changes on how logs work (Thanks to tgp1994)
Fix : app crash when disconnecting with null streams (Thanks to tgp1994) (Issue #48)
Fix : Correction of a bad state of the Notify Icon Text when the return value of ups status is not only "OL" (Issue #45)
Fix : Add -f parameter to force shutdown (Issue #46)
Added : Some modifications provided by tgp1994
Added : Addition of a directory containing the translations at the repository level.
		Makes it easier to submit a new translation (or correction) via a fork / pull request (nonPointer idea - issue # 35)
gawindx added a commit that referenced this issue Feb 5, 2021
###Version 2.0.7706
####Fix :
  - App crash when disconnecting with null streams (Thanks to tgp1994) (Issue #48)
  - Correction of a bad state of the Notify Icon Text when the return value of ups status is not only "OL" (Issue #45)
  - Add -f parameter to force shutdown (Issue #46)
  - Some modifications provided by tgp1994
  - Fixed a bug that could occur when using a value of "0" for the grace period (thanks to jcsmook - pull requests #55)
  - Fixed a bug generating an infinite connection / reconnection loop when the load value is retrieved to "0" during connection (thanks to jcsmook, pull requests # 55)
  - Correction of a code error causing the event time not to be updated in the logs.
  - Fixed an error causing an unhandled exception when you do not want to apply the update immediately and the installation file already exists at the location specified for saving.
  - In the case of a left click on the systray icon, WinNUT was restored to its original size and the context menu was opened at the same time.
  This behavior has been corrected and only the context menu opens.
  Restoring the WinNUT window to its original size is caused by a single or double click only.

####Added :
  - Addition of a directory containing the translations at the repository level.
	Makes it easier to submit a new translation (or correction) via a fork / pull request (nonPointer idea - issue #35)
  - Translation of the "List UPS Variable's" interface (translation forgot during v2.0)

####Changed :
  - Some changes on how logs work (Thanks to tgp1994)
  - Modification of the code to recover the power supply frequency of the UPS when it only provides the output frequency (modification made in response to an unsuccessful commit of pull requests # 55 - problem encountered by jcsmook)
  - Modification of the generated installer:
		- Addition of a custom image banner
		- Removal of the dependent Windows libraries installed in the WinNUT directory
  - The update process is no longer based on the "changelog.txt" of the repository but on the list of releases via the GitHub APIs.
  This modification has been implemented to avoid reproducing issue #53.
  This modification also brings the possibility of receiving both stable and development updates for those who choose to follow the development channel (the more recent of the two being the proposed update).
  - The changes made to the update process allow the implementation of a more suitable versioning of the type
    [Major Version].[Minor Version].[Automatic Build Version].[Automatic Revision Version]
  - Complete syntax review of Changelog.txt file
@gawindx
Copy link
Owner

gawindx commented Feb 9, 2021

The functionality is present in the new version, I close the issue but do not hesitate to reopen it if it does not correspond exactly or it can be improved.

@gawindx gawindx closed this as completed Feb 9, 2021
@Alian51
Copy link
Author

Alian51 commented Feb 12, 2021

Great! Just tested and it works!
Thanks for the follow-up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants