Warning instead of error (#356)

Warning instead of error
gauntface · Dec 11, 2022 · f450747 · f450747
1 parent b36f4cd
commit f450747
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/manipulations/opengraphimg/opengraphimg.go b/manipulations/opengraphimg/opengraphimg.go
@@ -18,6 +18,7 @@ package opengraphimg
 
 import (
 	"fmt"
+	"log"
 	"sort"
 	"strings"
 	"sync"
@@ -63,7 +64,8 @@ func Manipulator(runtime manipulations.Runtime, doc *html.Node) error {
 
 		img, err := getSuitableImg(runtime, c.Val)
 		if err != nil {
-			return err
+			log.Printf("Warning: Unable to find suitable image for %q: %v", c.Val, err)
+			continue
 		}
 
 		if img == nil {

diff --git a/manipulations/opengraphimg/opengraphimg_test.go b/manipulations/opengraphimg/opengraphimg_test.go
@@ -58,13 +58,13 @@ func TestManipulator(t *testing.T) {
 			wantHTML:    `<html><head><meta property="og:image"/></head><body></body></html>`,
 		},
 		{
-			description: "return error if getting images fails",
+			description: "do nothing if getting images fails",
 			findNodes:   htmlparsing.FindNodesByTag,
 			doc:         MustGetNode(t, `<meta property="og:image" content="/images/default-social.png" />`),
 			genimgsLookupSizes: func(s3 *s3.Client, conf *config.Config, imgPath string) ([]genimgs.GenImg, error) {
 				return nil, errInjected
 			},
-			wantError: errInjected,
+			wantHTML: `<html><head><meta property="og:image" content="/images/default-social.png"/></head><body></body></html>`,
 		},
 		{
 			description: "do nothing when no images",