WPGatsby Stability #74

jasonbahl · 2020-12-08T01:14:41Z

This Pull Request works toward getting the plugin more stable by doing the following:

TESTS: This PR adds a LOT of tests for the Action Monitor.
Refactored Action Monitors: Instead of one file that tries to track all actions, we now have many files with their own Monitor classes dedicated to tracking specific actions of specific types of data.
JWT Secret Set once: Now, instead of re-generating the JWT Secret until WPGatsby settings are saved, this generates it only if it's not yet been saved once, and saves it.

This PR addresses the following issues:

Trigger Action Monitor Action when ACF Field Groups are saved #70: When field groups are saved using ACF Field Group GUI, a "Diff Schema" action is triggered
Add: REFETCH_ALL action type #58: A "Refetch All" action is available and is used when Permalinks are changed
term meta is not being tracked #57: Term meta is now properly tracked when changed
Custom posts type posts aren't deleted when i switch them from 'publish' to 'trash' #56: Custom post types (all post types that are public and show_in_graphql) are now tracked when they are moved from publish to trash and vis-versa
Add Codeception Tests #41: Codeception tests are now in place
Whitelist WP options and send action monitor action to re-sync non-node root field data #38: Many core WordPress options have been added to an allow-list and trigger a general NON_NODE_ROOT_FIELDS action. A few specific actions trigger specific actions for specific nodes. For example, changing the home_page triggers an update for the new page and the old page being changed as the URI is now different.
Scheduled posts don't trigger build (Gatsby Cloud) #26: Posts that transition from future->publish now trigger an action (ensuring WordPress cron is triggered for WordPress sites using Gatsby front-ends might need more thought still though. . .)
modifyMeta() method is not set up to work with Users #17: Meta is now tracked for Posts, Terms and Users (comments are not currently tracked at the moment)
Re-saving permalinks or options should trigger an action #15: Saving permalinks triggers a REFETCH_ALL Action
Code to generate Gatsby Preview JWT Secret running on every request #7: Gatsby JWT Secret is now generated once and saved immediately and not generated again
Opt in to tracking post types instead of opting out #6: Gatsby now tracks only post_types (and taxonomies) that are set to be both public and show_in_graphql and there are filters to override as needed.

# Conflicts: # src/ActionMonitor/ActionMonitor.php

…expensive-meta-queries # Conflicts: # src/ActionMonitor/ActionMonitor.php

- add support for create, update, delete of Media, Nav Menus, Nav Menu Items, Posts (of all tracked post types), Terms (of all tracked taxonomies), Post Type/Taxonomy registry changes, and Users. - Fixed `preview_jwt_secret` setting to save once if it doesn't yet exist.

TylerBarnes

Overall this is incredible and such a valuable PR! There are just a couple small things I noticed

Thing 1:

The user isn't updated when saving a post anymore. We need the user node to update so it has the correct list of child pages/posts/cpts attached to it.

On the first save of a post I saw that it tried to delete a post as a user:

I'm not sure where "A published post" came from because I don't have a post or user called that

On further updates I don't see that anymore but I don't see the author being updated either:

Thing 2:

The title is displayed in the terminal output so we want to adjust the action monitor titles to account for that for all the different node types:

Ideally it'd still say "create page New page 2" instead of "create page CREATE New page 2". Same for other types. Generally the action monitor title should be the title of the thing being changed.

We could change it on the source plugin side so it shows the action monitor title instead of building a string out of the action type, name, and type, but that would be a breaking change 🤔 it's probably easier to keep the action monitor titles the same as the thing they're tracking.

For any reference fields it might be nicer to return null instead of "none" to make it more gql-like :)

Holy crap, updating the homepage works!! 💜 🔥 🔥 that's so awesome!
And settings! 🚀 🚀 🚀

The post type stuff is amazing 😱 this is all amazing!

TylerBarnes · 2020-12-10T00:55:58Z

Oo 2 more small things. 1: I think we need to merge master in here. I merged it locally but I'm not sure if I resolved the conflict properly. 2: Could you add an ## Upcoming section to the changelog.md so it'll be easier to release once we merge. Thanks!

…wer versions of phpunit have a breaking change - update titles of actions, per code review - update post monitor to log user action when post authors are changed - add test for changing authors on a post, to ensure it creates actions for the post and the previous and new author

- remove unused insertNewAction function from ActionMonitor.php

…wpgatsby-stability # Conflicts: # CHANGELOG.md # src/ActionMonitor/ActionMonitor.php # src/Admin/Preview.php

This reverts commit 5601181.

…tch what we test for.

- run php-cs to update code style

acao

tested these changes locally with the latest source plugin, and not only do they fix some issues with the latest release of wpgatsby, the schema seems to be resolving more quickly. great work!

- update test for re-assigning authors. This will be a breaking test now.

TylerBarnes

Jason and I just spent 5 hours reviewing this whole thing 😱 and it's ready to merge and release! :D

We're waiting until Monday because we need to make a new source plugin release at the same time since this is a breaking change.

acao · 2020-12-12T00:56:55Z

awesome work! yeah all the tests are passing with this branch against the source plugin primary branch.

- Update UserMonitor to track posts that need to be re-assigned and log the action for each post - Update ActionMonitorTest to properly test reassigning posts after a user is deleted - Add test for deleting menus

TylerBarnes

Just a couple more changes!

src/ActionMonitor/Monitors/NavMenuMonitor.php

TylerBarnes · 2020-12-15T01:49:32Z

src/ActionMonitor/Monitors/UserMonitor.php

 	/**
 	 * Initialize UserMonitor Actions
 	 *
 	 * @return mixed|void
 	 */
-	public function init() {
+	public function init() {if ( ! empty( $post_ids ) && is_array( $post_ids ) )  {


Looks like the formatting is a bit weird here. And where does $post_ids come from? Is that a global?

😱 this was some funky copy-pasta.

src/ActionMonitor/Monitors/UserMonitor.php

… of the name "Menu" as a prefix - Update code formatting in PostMonitor.php - remove copy-pasta from UserMonitor.php - Update action log for delete and re-assign to only log actions for published posts that are being re-assigned

TylerBarnes · 2020-12-15T19:26:14Z

@jasonbahl is this ready?

jasonbahl · 2020-12-15T19:28:02Z

@TylerBarnes I think so!

TylerBarnes · 2020-12-15T19:44:19Z

Looks and works great :D again, amazing work @jasonbahl , so stoked about this! I'll merge and release shortly

jasonbahl added 4 commits December 1, 2020 12:21

Merge branch 'master' into bug/#59-expensive-meta-queries

70c1825

# Conflicts: # src/ActionMonitor/ActionMonitor.php

Merge commit 'd81424852e49536c4a0a431434554bfd5539e65f' into bug/#59-…

d37ee0e

…expensive-meta-queries # Conflicts: # src/ActionMonitor/ActionMonitor.php

- add support for ACF Field Groups to trigger Action Monitor Actions

051659b

jasonbahl requested review from smthomas and TylerBarnes December 8, 2020 01:14

jasonbahl self-assigned this Dec 8, 2020

jasonbahl mentioned this pull request Dec 8, 2020

Bug/#6 only track specific post types #69

Closed

- Update how default JWT Setting is set

f801a5e

TylerBarnes suggested changes Dec 10, 2020

View reviewed changes

jasonbahl added 18 commits December 10, 2020 15:34

- Add "Upcoming" Section to the changelog

442c484

- remove unused insertNewAction function from ActionMonitor.php

Merge commit '1bbc3d34bb8d0b567e0841e75ba48f82839d4260' into feature/…

839eb39

…wpgatsby-stability # Conflicts: # CHANGELOG.md # src/ActionMonitor/ActionMonitor.php # src/Admin/Preview.php

- fix test for user deletes

b7f9dac

- remove hirak/prestissimo dependency

ea05ed4

- update codesniffer installer

96dd639

no message

9cbb6ce

no message

b2df592

no message

c318e20

- update composer.json

5601181

Revert "- update composer.json"

cd6add0

This reverts commit 5601181.

no message

df58ee3

no message

24a9ad3

- set the PHP version to 7.3 and the WordPress version to 5.4.2 to ma…

1ff10fb

…tch what we test for.

no message

0e11434

- updating action monitor titles and statuses

c0dc5b2

- run php-cs to update code style

no message

323dbac

- updating term ids

7ef5dd4

acao approved these changes Dec 11, 2020

View reviewed changes

jasonbahl added 2 commits December 11, 2020 14:14

- updating user ids to be cast as integers

2c1c07a

- update menu item IDs to use ->ID instead of ->term_id

fcc11bc

- update test for re-assigning authors. This will be a breaking test now.

TylerBarnes self-requested a review December 11, 2020 23:19

TylerBarnes approved these changes Dec 11, 2020

View reviewed changes

- Update NavMenuMonitor to properly track delete_nav_menu action

52ad7fe

- Update UserMonitor to track posts that need to be re-assigned and log the action for each post - Update ActionMonitorTest to properly test reassigning posts after a user is deleted - Add test for deleting menus

TylerBarnes self-requested a review December 15, 2020 01:44

TylerBarnes suggested changes Dec 15, 2020

View reviewed changes

TylerBarnes self-requested a review December 15, 2020 19:32

TylerBarnes approved these changes Dec 15, 2020

View reviewed changes

TylerBarnes merged commit 8ae13f3 into master Dec 15, 2020

This was referenced Mar 17, 2021

Code to generate Gatsby Preview JWT Secret running on every request #7

Closed

Trigger Action Monitor Action when ACF Field Groups are saved #70

Closed

TylerBarnes deleted the feature/wpgatsby-stability branch March 18, 2021 17:53

psharma-ii mentioned this pull request Aug 27, 2021

Trigger_Refetch_All not triggering a rebuild of the entire site #190

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WPGatsby Stability #74

WPGatsby Stability #74

jasonbahl commented Dec 8, 2020

TylerBarnes left a comment •

edited

Loading

TylerBarnes commented Dec 10, 2020

acao left a comment •

edited

Loading

TylerBarnes left a comment

acao commented Dec 12, 2020

TylerBarnes left a comment

TylerBarnes Dec 15, 2020

jasonbahl Dec 15, 2020

TylerBarnes commented Dec 15, 2020

jasonbahl commented Dec 15, 2020

TylerBarnes commented Dec 15, 2020

WPGatsby Stability #74

WPGatsby Stability #74

Conversation

jasonbahl commented Dec 8, 2020

TylerBarnes left a comment • edited Loading

Choose a reason for hiding this comment

TylerBarnes commented Dec 10, 2020

acao left a comment • edited Loading

Choose a reason for hiding this comment

TylerBarnes left a comment

Choose a reason for hiding this comment

acao commented Dec 12, 2020

TylerBarnes left a comment

Choose a reason for hiding this comment

TylerBarnes Dec 15, 2020

Choose a reason for hiding this comment

jasonbahl Dec 15, 2020

Choose a reason for hiding this comment

TylerBarnes commented Dec 15, 2020

jasonbahl commented Dec 15, 2020

TylerBarnes commented Dec 15, 2020

TylerBarnes left a comment •

edited

Loading

acao left a comment •

edited

Loading