Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Why doesn’t Peril seem to be actually adding labels? #22

Closed
jlengstorf opened this issue Aug 3, 2018 · 8 comments
Closed

Why doesn’t Peril seem to be actually adding labels? #22

jlengstorf opened this issue Aug 3, 2018 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@jlengstorf
Copy link
Contributor

What about now? cc @piotrkwiecinski @SD10

@jlengstorf
Copy link
Contributor Author

Hmmm... It ran on Heroku, but nothing happened. I have to run now, but will look into adding logging later today.

@jlengstorf jlengstorf changed the title How does this work? Why doesn’t Peril seem to be actually adding labels? Aug 4, 2018
@jlengstorf jlengstorf self-assigned this Aug 4, 2018
@jlengstorf jlengstorf added the bug Something isn't working label Aug 4, 2018
@SD10
Copy link
Contributor

SD10 commented Aug 4, 2018

Checklist:

  • Has the peril server on Heroku been restarted?
  • Does the peril app have permissions to edit issues?
  • Is the peril app subscribed to issue related events?

Other thoughts:

@piotrkwiecinski
Copy link
Contributor

Is the app installed for all repositories or gatsby/selected repositories?

@jlengstorf
Copy link
Contributor Author

The labeler is being triggered without errors, so maybe we should add console logging to figure out where it dies.

screenshot_20180804-151559

@piotrkwiecinski
Copy link
Contributor

I've started setting up peril on my own heroku account, so should be able to play around more with it tomorrow.

jlengstorf pushed a commit that referenced this issue Aug 16, 2018
Refs: #22 

I had some issues with setting up peril for my account. Didn't have time to debug the setup, so at least I've added few debug logs + label without colon just to test.

@jlengstorf @SD10
@jlengstorf
Copy link
Contributor Author

I updated Peril, and I started getting errors. Still can't get console logs out of the labeler task. Posted an issue at danger/peril#351

I'm at a bit of a loss at this point, so will wait to hear back on this issue.

A few other things got weird as well (triple-firing, for example). Not sure if that's related to the work we've been doing here or something else, but need to figure out what's happening.

@jlengstorf
Copy link
Contributor Author

I just rolled back in hopes of restoring the working PR integration.

@jlengstorf
Copy link
Contributor Author

So this works now, but there seems to be a problem with running multiple tasks, and I'm still hitting errors in the latest release of Peril. Once @orta is back around I'll see if I can help track down how/why that's happening.

For now, closing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants