Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add total npm downloads badge #9926

Merged
merged 4 commits into from
Nov 15, 2018
Merged

Conversation

aadibajpai
Copy link
Contributor

The total figure is much higher (6 million) than the monthly rate and quite a lot more impactful. So, it should make for a better listing on the readme :)

@KyleAMathews
Copy link
Contributor

The total number is nice! :-)

But current velocity is more interesting to us as that's a stronger indication of current usage — which is what people really care about. Also monthly downloads is a common thing to share so it's easier to compare us to other projects this way.

@aadibajpai
Copy link
Contributor Author

What do you think about both, then? That whopping 6 million figure packs a punch! @KyleAMathews

@KyleAMathews
Copy link
Contributor

sure :-)

@KyleAMathews KyleAMathews reopened this Nov 14, 2018
@KyleAMathews
Copy link
Contributor

Looks like there's a conflict now?

@aadibajpai
Copy link
Contributor Author

Should be okay now :)

@pieh pieh changed the title [Improvement] Show total npm downloads instead of monthly readme: add total npm downloads badge Nov 15, 2018
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aadibajpai!

@pieh pieh merged commit 19fc4ca into gatsbyjs:master Nov 15, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 15, 2018

Holy buckets, @aadibajpai — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@aadibajpai aadibajpai deleted the patch-1 branch December 15, 2018 15:42
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
The total figure is much higher (6 million) than the monthly rate and quite a lot more impactful. So, it should make for a better listing on the readme :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants