-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-drupal): add support for Drupal JSON API 2.x File URI format #9835
Conversation
Co-Authored-By: dcorb <david.corbacho@wunder.io>
Thanks @kakadiadarpan . Suggestion applied |
This looks good. Adding test would be great - we would need to add new entry in this fixture https://github.com/gatsbyjs/gatsby/blob/4db5cdcce9b78db65454935e322f3d61d1c82179/packages/gatsby-source-drupal/src/__tests__/fixtures/file.json that uses new URI format And then in actual test mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dcorb!
Holy buckets, @dcorb — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
👍 |
…URI format (gatsbyjs#9835) Description of the issue gatsbyjs#9834 (If this approach is correct, I could add a test for this case)
Description of the issue
#9834
(If this approach is correct, I could add a test for this case)