Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): add Ecosystem section to Homepage #9783

Merged
merged 18 commits into from
Nov 14, 2018
Merged

feat(www): add Ecosystem section to Homepage #9783

merged 18 commits into from
Nov 14, 2018

Conversation

greglobinski
Copy link
Contributor

  • add featured items to IndexRoute's pageContext
  • add new version of Button//
  • add className props to Ecosystem components for restyling
  • refactor ecosystem/ecosystem-featured-items.js for restyling
  • create universal HomepageSection component
  • create HomepageEcosystem component with all content of Ecosystem section
  • change GraphQL query for IndexRoute (+ refactor data destructing )
  • add new color Lemon to the pallete, the featured items cards colors used in the Ecosystem section are defined in the code. (@fk would you have the also in the palette?)

@greglobinski
Copy link
Contributor Author

@amberleyromo amberleyromo changed the title feat(www): add Ecosystem section to Homepage [WIP] feat(www): add Ecosystem section to Homepage Nov 7, 2018
@amberleyromo
Copy link
Contributor

@greglobinski revisit the card hover state?

screen shot 2018-11-07 at 10 00 44 am

@greglobinski
Copy link
Contributor Author

greglobinski commented Nov 7, 2018

@amberleyromo , yeah I thought that I fixed it but seams that not, thanks

@amberleyromo
Copy link
Contributor

amberleyromo commented Nov 7, 2018

A few content changes, as well (from #9747)

  • Change the intro text (below Plugins & Starters) to:

With over 527 plugins, 86 starters, and dozens of tutorials, the Gatsby ecosystem has tools to help you build your Gatsby projects.

(I agree with @lindaleebumblebee, i think it needs to be shorter, let's go with this one)

  • Change the text of two of the links under Plugins section
    • "Plugin Docs" => "Using Plugins"
    • "Plugin Authoring" => "Creating Plugins"
  • For consistency, change the text of the link under Starters section also
    • "Starter Docs" => "Using Starters"

@greglobinski
Copy link
Contributor Author

@amberleyromo

  • hover bug fixed
  • intro & label texts changed

Should I also make a PR with the changes for the link labels on the Ecosystem page?

@amberleyromo
Copy link
Contributor

This looks great to me!

I'd say go ahead and make the content changes to the ecosystem landing page as part of this PR -- it's not a huge change. Thanks for thinking about it.

I'm good to go on this personally, but would also love @DSchau's eye also on your review request re: styling... style.

Please take a close look at the restyled/reused Emotion components in https://github.com/gatsbyjs/gatsby/pull/9783/files#diff-623d03a8cfeefafaac1d88a99eb22dd2 derived from /ecosystem/* components in the context of our emerging 'way of styling'

@greglobinski
Copy link
Contributor Author

@amberleyromo

  • move scrollers intersectionObserver to an outer module, so both pages Index and Ecosystem use the same code www/src/utils/scrollers-observer.js
  • refactor featuredItems observer to scrollerWithLead observer, it's ready now to work with another scrollers which will appear in coming Homepage sections (e.g. Blog)
  • change buttons labels on Ecosystem page for consistency with Homepage Ecosystem section

Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end. Left a few comments!

www/src/components/homepage/homepage-ecosystem.js Outdated Show resolved Hide resolved
www/src/pages/index.js Outdated Show resolved Hide resolved
www/src/utils/scrollers-observer.js Show resolved Hide resolved
@fk
Copy link
Contributor

fk commented Nov 13, 2018

@greglobinski Sorry for not seeing this earlier.

add new color Lemon to the pallete, the featured items cards colors used in the Ecosystem section are defined in the code. (@fk would you have the also in the palette?)

Yay 🍋! ;-)

Yes, I would add those featured item card colors to colors, too. I like to think this gives us a better starting point for eventually refactoring colors — I think we should abandon the "named" color model sooner or later, and move to base color and shades similar to what Material Design does or is outlined here, or a simpler and tighter definition like http://www.carbondesignsystem.com/guidelines/color/swatches; in any case, abandon names like lavender or wisteria.

@greglobinski
Copy link
Contributor Author

greglobinski commented Nov 13, 2018

I think we should abandon the "named" color model sooner or later,

I agree with that, but for now what names I should use to add the Starter/Plugins colors to the palette?
@fk

www/src/utils/colors.js Outdated Show resolved Hide resolved
@fk
Copy link
Contributor

fk commented Nov 13, 2018

@greglobinski Here's how I've (inconsistently 🙄) named them in Figma for now:

image

I think we're using

  • accentLight
  • accentDark
  • skyDark
  • skyLight

for the "Plugins" and "Starter" card labels with the 90° rotated text.

Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice IMO to remove setting a width for the starter/plugin cards container, and adding a couple more colors to the palette, both as discussed inline.

Other than that LGTM, too! 💜🙏

@greglobinski
Copy link
Contributor Author

@amberleyromo @fk

  • remove width setting for the scroller container
  • add plugins/starters colors to the palette
  • update featured starter list

@amberleyromo amberleyromo merged commit 766ea4c into gatsbyjs:master Nov 14, 2018
@greglobinski greglobinski deleted the gl/homepage/ecosystem branch November 15, 2018 22:16
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
* feat(www): add Ecosystem section to Homepage

feat(www): homepage WIP

wip

feat(www): finish sections style for mobile

feat(www): add Ecosystsem featured items to Hompage

feat(www): homepage ecosystem section styling WIP

feat(www): add arrow to action button

* fix(www): fix code formating

* fix(www): fix code formating and eslint errors

* fix(www): fix hovering effect on Featured Item

* fix(www): fix hovering effect sequel

* fix(www): fix hover bug

* fix(www): update texts (intro & link labels)

* feat(www): add scroller observer to Home page

* refactor(www): use imported scrollers observer

* fix(www): change link labes on Ecosystem page

* fix(www): fix some small style issues

* refactor(www): refator combineEcosystemFeaturedItems and reorder some css properties

* refactor(www): remove width setting from scroller container

* fix(www): update featured starters

* fix(www): update featured starters

* refactor(www): add starter/plugins colors to the palette

* fix(www): remove unused props

* fix(www): fix color value in the palette
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants