-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(www): add Ecosystem section to Homepage #9783
feat(www): add Ecosystem section to Homepage #9783
Conversation
|
@greglobinski revisit the card hover state? |
@amberleyromo , yeah I thought that I fixed it but seams that not, thanks |
A few content changes, as well (from #9747)
(I agree with @lindaleebumblebee, i think it needs to be shorter, let's go with this one)
|
Should I also make a PR with the changes for the link labels on the Ecosystem page? |
This looks great to me! I'd say go ahead and make the content changes to the ecosystem landing page as part of this PR -- it's not a huge change. Thanks for thinking about it. I'm good to go on this personally, but would also love @DSchau's eye also on your review request re: styling... style.
|
feat(www): homepage WIP wip feat(www): finish sections style for mobile feat(www): add Ecosystsem featured items to Hompage feat(www): homepage ecosystem section styling WIP feat(www): add arrow to action button
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my end. Left a few comments!
@greglobinski Sorry for not seeing this earlier.
Yay 🍋! ;-) Yes, I would add those featured item card colors to |
I agree with that, but for now what names I should use to add the Starter/Plugins colors to the palette? |
@greglobinski Here's how I've (inconsistently 🙄) named them in Figma for now: I think we're using
for the "Plugins" and "Starter" card labels with the 90° rotated text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice IMO to remove setting a width for the starter/plugin cards container, and adding a couple more colors to the palette, both as discussed inline.
Other than that LGTM, too! 💜🙏
|
* feat(www): add Ecosystem section to Homepage feat(www): homepage WIP wip feat(www): finish sections style for mobile feat(www): add Ecosystsem featured items to Hompage feat(www): homepage ecosystem section styling WIP feat(www): add arrow to action button * fix(www): fix code formating * fix(www): fix code formating and eslint errors * fix(www): fix hovering effect on Featured Item * fix(www): fix hovering effect sequel * fix(www): fix hover bug * fix(www): update texts (intro & link labels) * feat(www): add scroller observer to Home page * refactor(www): use imported scrollers observer * fix(www): change link labes on Ecosystem page * fix(www): fix some small style issues * refactor(www): refator combineEcosystemFeaturedItems and reorder some css properties * refactor(www): remove width setting from scroller container * fix(www): update featured starters * fix(www): update featured starters * refactor(www): add starter/plugins colors to the palette * fix(www): remove unused props * fix(www): fix color value in the palette
IndexRoute
's pageContextButton
//className
props to Ecosystem components for restylingecosystem/ecosystem-featured-items.js
for restylingHomepageSection
componentHomepageEcosystem
component with all content of Ecosystem sectionIndexRoute
(+ refactor data destructing )Lemon
to the pallete, the featured items cards colors used in the Ecosystem section are defined in the code. (@fk would you have the also in the palette?)