Draft for Sourcing from Private APIs #9772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first draft for the docs. Appreciate feedback if there is anything that is incorrect, can be improved or additional content that could be added.
LekoArts
reviewed
Nov 7, 2018
Modified based on feedbacks from @LekoArts: 1. Add `gatsby-source-graphql` as an easy option if the private API is a GraphQL API. 2. Reword the consideration of alternative to be more general.
shannonbux
suggested changes
Nov 7, 2018
There was a problem hiding this comment.
Hi @malcolm-kee! This is looking good from a docs perspective except for one change. Will you change any words like "simple" to something more specific according to this part of the style guide? https://www.gatsbyjs.org/docs/gatsby-style-guide/#avoid-easy-and-simple
I made a few minor grammar edits. Thanks for filling out a stub! It's a huge help!
Thanks!
Follow the guidelines of style guide, reword "if you want something simple" to "if you are new to GraphQL".
|
Hi @shannonbux , I've changed the wording as suggested. |
gtsb-bot
approved these changes
Nov 12, 2018
calcsam
approved these changes
Nov 12, 2018
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
My first draft for the docs. Appreciate feedback if there is anything that is incorrect, can be improved or additional content that could be added. <!-- Q. Which branch should I use for my pull request? A. Use `master` branch (probably). Q. Which branch if my change is a bug fix for Gatsby v1? A. In this case, you should use the `v1` branch Q. Which branch if I'm still not sure? A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first draft for the docs. Appreciate feedback if there is anything that is incorrect, can be improved or additional content that could be added.