chore: manual eslint fixes #9750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lipis |
pieh
commented
Nov 6, 2018
|
|
||
| class CommunityHeader extends Component { | ||
| render() { | ||
| const { forHire, hiring, submissionText } = this.props | ||
| const { /*forHire, hiring,*/ submissionText } = this.props |
There was a problem hiding this comment.
decided to comment out "unused vars" as rest of the code that was using that is commented - presumably can be used in future?
There was a problem hiding this comment.
commented out code should be removed in general from master.
pieh
commented
Nov 6, 2018
DSchau
reviewed
Nov 6, 2018
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env node | |||
| const util = require(`util`) | |||
| const exec = util.promisify(require(`child_process`).exec) | |||
There was a problem hiding this comment.
This should fix some things 🎉
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
* gatsbygram: consistent return * using-faker: fix linting * using-gatsby-source-graphql: import graphql from gatsby * using-remark-copy-linked-files: consistent return * gatsby-source-contentful: no-self-assign * cache-dir: consistent return, unused vars * add-npm-owner: re-add missing imports * fix www linting * gatsbygram: remove unused lifecycle methods * return null instead of fragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes problems that
eslint --fixcan't autofix