test: Separate the test for windows and others in gatsby-plugin-feed #8906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows uses different type of directory separator and it breaks the test cause of jest mock. The test will separate via it.skip() which jest provided as a temporary workaround.
|
Here's alternative fix for win32 - #8836 - upside for this one is you don't need to update separately snapshots for windows and unix |
|
Looks much better. Thanks @pieh, learning everyday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows uses a different type of directory separator and it breaks the test cause of jest mock.
Maybe the test should not use jest mock in this case but I can see the reason why it is used in here. The test will separate via
it.skip()which jest provided as a temporary workaround.