[1.0] Add the sass plugin to this repo #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfarrell
changed the title
|
This looks great! Thanks for adding this. Could you add me as an owner on NPM when you have a chance as well? Also, it looks like you planned to allow people to pass it options? It doesn't look like that was implemented yet? |
|
Oh haha NVM, just saw on NPM you already added me 👍 |
Can add this back once options get implemented
|
There should probably be some options eventually, but you are right that that isn't implemented yet. I just pulled that out of the README for now. |
|
Merged it locally! Thanks for the contribution! https://github.com/gatsbyjs/gatsby/tree/1.0/packages/gatsby-plugin-sass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #845, this probably belongs in this repo so I'm contributing it.