Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Plugin Authoring doc: publishing info #7733

Merged
merged 3 commits into from
Aug 31, 2018
Merged

[docs] Plugin Authoring doc: publishing info #7733

merged 3 commits into from
Aug 31, 2018

Conversation

hdoro
Copy link
Contributor

@hdoro hdoro commented Aug 29, 2018

I've added a couple of paragraphs under a new H2 for Publishing a plugin to the library to help with #4673 .

Instead of just adding a tiny note on how much time Algolia would take to add the page to the library, based on my previous experience, I thought it was best to create a new section on publishing as it could be a bit confusing for beginners (in the very least, it was for me). The wording is still probably a bit off, feel free to suggest changes 😄

PS: In the first section of this page we say we'll review "what a plugin is not", but I don't this in any explicit way here... what was your line of thought in including this?

closes #4673

I've added a couple of paragraphs under a new H2 for _Publishing a plugin to the library_ to help with #4673 .

Instead of just adding a tiny note on how much time Algolia would take to add the page to the library, based on my previous experience, I thought it was best to create a new section on publishing as it could be a bit confusing for beginners (in the very least, it was for me). The wording is still probably a bit off, feel free to suggest changes 😄 

**PS:** In the first section of this page we say we'll review "what a plugin is _not_", but I don't this in any explicit way here... what was your line of thought in including this?
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! A couple small changes, then I think this will be ready to go in.


## Publishing a plugin to the library

In order to add your plugin to the [Plugin Library], you need to simply publish a package to NPM (learn how [here](https://docs.npmjs.com/getting-started/publishing-npm-packages)) with the [required files](#what-files-does-gatsby-look-for-in-a-plugin) and **include a `keywords` field** to `package.json` containing `gatsby` and `gatsby-plugin`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to avoid words like "simply", because to a first-timer, publishing a package to npm may not feel simple. Could you remove "simply" here?

Also, npm branding dictates that their name is all lowercase.

@jlengstorf
Copy link
Contributor

Thanks so much for this, @hcavalieri!

RE: this question:

PS: In the first section of this page we say we'll review "what a plugin is not", but I don't this in any explicit way here... what was your line of thought in including this?

To be honest, I'm not sure what the original plan was for this. If it's unclear, we can tackle that in a follow-up PR to prevent this one from ballooning in scope.

@hdoro
Copy link
Contributor Author

hdoro commented Aug 31, 2018

@jlengstorf great point on the usage of "simply"! I myself felt quite intimidated about publishing a package, until I did it hahah

GitHub tells me you've made some changes but I couldn't see them, so I went ahead and commited a new version without this word and using "npm" ;)

On my question: let me know what you find out, I'd be glad to help doing this other PR 😄

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hcavalieri 👍

That what a plugin is not section was recently moved to the plugin overview page. As we're talking about it anyway I went ahead and removed the redundant header.

@m-allanson m-allanson merged commit 965b51e into gatsbyjs:master Aug 31, 2018
@gatsbot
Copy link

gatsbot bot commented Aug 31, 2018

Holy buckets, @hcavalieri — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Algolia notes to Plugin Authoring doc
3 participants