Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] docs - update page query docs #7285

Merged
merged 8 commits into from
Aug 13, 2018

Conversation

amberleyromo
Copy link
Contributor

@amberleyromo amberleyromo commented Aug 13, 2018

closes #7278

Changes:

docs/build-a-page-with-graphql-query

  • worked toward consistency with the static query docs
    • renamed this page to docs/page-query. These docs were tucked away in an "example" style page; for documentation (as opposed to tutorial style), I thought it made a lot more sense to have the page-query/static-query documentation be patterned similarly.

docs/static-query

  • slight edits for consistency with docs/page-query docs.

sidebars/doc-links

  • reordered to reflect the change in architecture: creating pages, then page query, then StaticQuery

tutorial/part-four

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 13, 2018

Deploy preview for using-postcss-sass failed.

Built with commit 2463358

https://app.netlify.com/sites/using-postcss-sass/deploys/5b720854c965926b051414e5

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 13, 2018

Deploy preview for using-contentful failed.

Built with commit 2463358

https://app.netlify.com/sites/using-contentful/deploys/5b720856c965926b051414f4

@KyleAMathews
Copy link
Contributor

Deploy preview for using-jss failed.

Built with commit 85f13da

https://app.netlify.com/sites/using-jss/deploys/5b71d1dbdd28ef1b1bd94650

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 13, 2018

Deploy preview for using-drupal ready!

Built with commit 2463358

https://deploy-preview-7285--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 13, 2018

Deploy preview for gatsbygram ready!

Built with commit 2463358

https://deploy-preview-7285--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 13, 2018

Deploy preview for gatsbyjs failed.

Built with commit 2463358

https://app.netlify.com/sites/gatsbyjs/deploys/5b720853c965926b051414d9

m-allanson
m-allanson previously approved these changes Aug 13, 2018
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice, thanks @amberleyromo!

jlengstorf
jlengstorf previously approved these changes Aug 13, 2018
Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

---

Gatsby v2 introduces `StaticQuery`, a new API that allows components to retrieve data via GraphQL query.

## Basic example
In this guide, we'll walk through an example using `StaticQuery`, and discuss [the difference between a StaticQuery and a page query](/static-query/#how-staticquery-differs-from-page-query).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to end up with a merge conflict in #7249, but otherwise I'm into it. 😄

@jlengstorf jlengstorf dismissed stale reviews from m-allanson and themself via 2463358 August 13, 2018 22:38
@jlengstorf jlengstorf merged commit 9ea5c36 into gatsbyjs:master Aug 13, 2018
m-allanson added a commit to phacks/gatsby that referenced this pull request Aug 14, 2018
* master: (597 commits)
  Add a site(https://mojaave.com) to showcase list (gatsbyjs#7275)
  feat: create a doc for open source pair programming sessions (gatsbyjs#7266)
  [docs] Add video lesson to the StaticQuery docs (gatsbyjs#7249)
  [v2] docs - update page query docs (gatsbyjs#7285)
  [v2] docs "Styling" overview (gatsbyjs#7288)
  Remove delay (gatsbyjs#7273)
  add site (gatsbyjs#7291)
  Adding new site to the showcase. (gatsbyjs#7281)
  chore(release): Publish
  initial webpack externals support (gatsbyjs#7245)
  add missing package dependencies (gatsbyjs#7259)
  add: custom configuration overview
  (gatsbyjs#7231): tutorial part four updates (gatsbyjs#7240)
  [www] Fix showcase search, checkbox styles (gatsbyjs#7014)
  (gatsbyjs#6584): Restructure plugin overview and plugin authoring pages (gatsbyjs#7229)
  Use Hubspot form for email subscription (gatsbyjs#7233)
  Adding bootstrap CV starter (gatsbyjs#7207)
  Stub Articles and new names (gatsbyjs#7200)
  Improve readability of verbose logging code in wordpress source plugin (gatsbyjs#7146)
  Update hash link to scroll to right section of page (gatsbyjs#7161)
  ...
porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
* (gatsbyjs#7278): Update graphql and static query doc organization to pattern consistently

* (gatsbyjs#7278): move graphql tag explanation from tutorial to page query docs

* (gatsbyjs#7278): remove intro paragraph, no longer necessary after restructuring

* (gatsbyjs#7278): add language to StaticQuery intro

* (gatsbyjs#7278): add link to page-query doc in tutorial part four

* (gatsbyjs#7278): distinct heading levels for sections

* (gatsbyjs#7278): consistent intro style on page-query, alter graphql explanation for different context

close gatsbyjs#7278
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] docs - update page query docs
5 participants