Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new blog post about Gatsby's pair programming #7253

Merged
merged 7 commits into from
Aug 15, 2018

Conversation

horacioh
Copy link
Contributor

No description provided.

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 12, 2018

Deploy preview for using-postcss-sass failed.

Built with commit d3af04c

https://app.netlify.com/sites/using-postcss-sass/deploys/5b70b494c6aed664482dfe7d

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 12, 2018

Deploy preview for gatsbyjs failed.

Built with commit d3af04c

https://app.netlify.com/sites/gatsbyjs/deploys/5b70b492c6aed664482dfe72

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 12, 2018

Deploy preview for using-drupal ready!

Built with commit d3af04c

https://deploy-preview-7253--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 12, 2018

Deploy preview for gatsbygram ready!

Built with commit d3af04c

https://deploy-preview-7253--gatsbygram.netlify.com

@pieh
Copy link
Contributor

pieh commented Aug 12, 2018

/cc @jlengstorf

Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @horacioh! A couple things to add, and once #7266 merges I think this will be ready to go!


A couple of weeks ago, we were planning to rebuild our websites using Gatsby, and then I saw this:

![Jason's Tweet](images/tweet.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap this out for the embedded tweet? https://twitter.com/jlengstorf/status/1016721019376025600

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

### On a scale of 1–10, how likely are you to recommend it to a friend? (1–10 scale)

10! No doubt. And higher than 10 if you have never done pair programming. Just take a simple task and go! It’s not about the code you will write, but the experience of developing with an expert. It’s just amazing. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a link to the pair programming doc and a call to action so people know how to get a spot?

Something like:

If you want to sign up for your session, check out the [open community pair programming sessions docs and signup instructions](/docs/pair-programming/).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@horacioh
Copy link
Contributor Author

horacioh commented Aug 12, 2018

@jlengstorf changes done! thanks for the review :)

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @horacioh 👍

@horacioh
Copy link
Contributor Author

now this could be merged right? @jlengstorf

@jlengstorf jlengstorf merged commit b0c8785 into gatsbyjs:master Aug 15, 2018
@pieh
Copy link
Contributor

pieh commented Aug 16, 2018

@horacioh Hey, we didn't notice this in PR review, but we need to update https://github.com/gatsbyjs/gatsby/blob/master/docs/blog/author.yaml with your data - I don't have nice photo of You, so I would appreciate if you could add that data and your photo to /docs/blog/avatars directory in follow up PR

@pieh
Copy link
Contributor

pieh commented Aug 16, 2018

@horacioh Actually, I'll grab photo from github for now and if you wish, You can swap it later on

@horacioh horacioh deleted the blog/pair-programming-post branch August 16, 2018 11:11
@horacioh
Copy link
Contributor Author

@pieh perfect!

thanks!! 🎉

porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants