Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added three new sections to the docs #7121

Merged
merged 3 commits into from
Aug 9, 2018

Conversation

shannonbux
Copy link
Contributor

@shannonbux shannonbux commented Aug 7, 2018

The "Testing" section already has a few PRs about to be merged.
#6708
#6678

Will need to make stub articles for the "Sourcing content and data" section and the "Adding third-party services" section.

@calcsam I don't know if I did the "Headless CMS" section inside the "Sourcing content and data" section correctly. Also, this process is giving me pause on how many levels of infinite nesting is reasonable. There is a point at which we'd need to actually create a whole new page for a set of docs if it has enough children with grand-children and great-great-grand-children, etc!

The "Testing" section already has a few PRs about to be merged.

Will need to make stub articles for the "Sourcing content and data" section and the "Adding third-party services" section.

@calcsam I don't know if I did the "Headless CMS" section inside the "Sourcing content and data" section correctly. Also, this process is giving me pause on how many levels of infinite nesting is reasonable. There is a point at which we'd need to actually create a whole new page for a set of docs if it has enough children with grand-children and great-great-grand-children, etc!
@shannonbux shannonbux added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Aug 7, 2018
@shannonbux shannonbux requested a review from calcsam August 7, 2018 17:53
@shannonbux
Copy link
Contributor Author

shannonbux commented Aug 7, 2018

@KyleAMathews looping you in here too

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 7, 2018

Deploy preview for gatsbyjs failed.

Built with commit 6ecd97c

https://app.netlify.com/sites/gatsbyjs/deploys/5b6c995c02ed8373d953cd62

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 7, 2018

Deploy preview for using-postcss-sass failed.

Built with commit 6ecd97c

https://app.netlify.com/sites/using-postcss-sass/deploys/5b6c995d02ed8373d953cd6a

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 7, 2018

Deploy preview for using-drupal ready!

Built with commit 6ecd97c

https://deploy-preview-7121--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor

Deploy preview for image-processing failed.

Built with commit 6a01ea8

https://app.netlify.com/sites/image-processing/deploys/5b69dca4c6aed671bd1dd189

@KyleAMathews
Copy link
Contributor

Deploy preview for using-glamor failed.

Built with commit 6a01ea8

https://app.netlify.com/sites/using-glamor/deploys/5b69dca4c6aed671bd1dd18c

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Aug 7, 2018

Deploy preview for gatsbygram ready!

Built with commit 6ecd97c

https://deploy-preview-7121--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Deploy preview for using-jss failed.

Built with commit 6a01ea8

https://app.netlify.com/sites/using-jss/deploys/5b69dca7c6aed671bd1dd1aa

@KyleAMathews
Copy link
Contributor

Deploy preview for using-styled-components failed.

Built with commit 6a01ea8

https://app.netlify.com/sites/using-styled-components/deploys/5b69dca4c6aed671bd1dd18f

link: /docs/filesystem/
- title: Database*
link: /docs/database/
- title: SaaS service*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be pluralized

link: /docs/prose/
- title: Filesystem*
link: /docs/filesystem/
- title: Database*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be pluralized

link: /docs/contentful/
- title: Prose*
link: /docs/prose/
- title: Filesystem*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a strong opinion on link title? Thinking eg "From the filesystem" might be good, etc. Slug should be something that stands alone, eg /docs/sourcing-from-the-filesystem/ -- /docs/filesystem is a bit confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& other slugs should probably be changed as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying shorter ones because long ones look funny in the sidebar! The URL is important too. I'll try your suggestion and we can see how it looks

link: /docs/adding-third-party-services/
items:
- title: Search*
link: /docs/search/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More descriptive slugs? eg adding-search, adding-forms, adding-analytics?

@@ -83,19 +83,30 @@
link: /docs/programmatically-create-pages-from-data/
- title: Querying data with StaticQuery
link: /docs/static-query/
- title: Headless CMS*
link: /docs/headless-cms/
- title: Sourcing content and data*
Copy link
Contributor

@calcsam calcsam Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole section should be moved before the "Querying Data" section. We should be putting these sections in the order the user would be doing them, similar to the order in https://www.gatsbyjs.com/integrations/ or https://www.gatsbyjs.com/how-it-works/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(this could be done in a separate PR as well, obviously there's more re-ordering)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! @KyleAMathews initially helped put these in order, so we'll need to sync up about this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait, I was looking at the wrong section header for this comment. So, because Headless CMSs is within this category, wouldn't someone need to know how to query with GraphQL first before reading about Headless CMSs?

Copy link
Contributor

@KyleAMathews KyleAMathews Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal one way or the other but I agree with Sam here that someone new to Gatsby would first want to read a bit about how you can source data from anywhere before they move onto using graphql to pull that data into their components.

@calcsam
Copy link
Contributor

calcsam commented Aug 7, 2018

Left some comments -- thanks @shannonbux!

@calcsam
Copy link
Contributor

calcsam commented Aug 7, 2018

Re: Layers, right now we're at 4, which feels about right at the moment. I wouldn't go any deeper, but it feels like we need all of these layers, eg it's difficult to see how we would get rid of any of these layers:

Guides > Sourcing Content and Data > Headless CMS > Contentful

@shannonbux
Copy link
Contributor Author

Thanks @calcsam! I'll address your feedback right now and re: 4 layers, I agree we shouldn't go any deeper, and even this layer might look strange. I decided to give it a go and then look at the deploy preview to see if it functions ok (sometimes longer titles look funny in the sidebar). If we start feeling the need to go to 4 or 5 layers in a certain section so it's kind of "busting at the seams," we'll have to evaluate whether we need a dedicated page for that particular section. Even though the new hierarchy fits a lot more, it might not fit everything...

m-allanson
m-allanson previously approved these changes Aug 8, 2018
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shannonbux shannonbux merged commit 4a7f0fa into master Aug 9, 2018
@shannonbux shannonbux deleted the shannonbux-new-sidebar-child-items branch August 9, 2018 19:44
@ascorbic
Copy link
Contributor

Now this is merged, can we merge #6708 and #6678? Right now the menu links are broken.

porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
* Added three new sections to the docs

The "Testing" section already has a few PRs about to be merged.

Will need to make stub articles for the "Sourcing content and data" section and the "Adding third-party services" section.

@calcsam I don't know if I did the "Headless CMS" section inside the "Sourcing content and data" section correctly. Also, this process is giving me pause on how many levels of infinite nesting is reasonable. There is a point at which we'd need to actually create a whole new page for a set of docs if it has enough children with grand-children and great-great-grand-children, etc!

* Addressed Sam's feedback

* updated sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants