Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics/custom should update scroll #663

Merged
merged 3 commits into from
Feb 7, 2017
Merged

Topics/custom should update scroll #663

merged 3 commits into from
Feb 7, 2017

Conversation

Rusta
Copy link
Contributor

@Rusta Rusta commented Feb 7, 2017

Adds support for overriding the 'shouldUpdateScroll' function when changing between routes

@KyleAMathews
Copy link
Contributor

Nit picky but could the default function name be "defaultShouldUpdateScroll"?

@Rusta
Copy link
Contributor Author

Rusta commented Feb 7, 2017

sure, no problem - I've updated the function name as per your suggestion

@KyleAMathews
Copy link
Contributor

Perfect! Will merge and release, thanks!

@KyleAMathews KyleAMathews merged commit 2f59c2f into gatsbyjs:master Feb 7, 2017
@jlengstorf
Copy link
Contributor

Hiya @Rusta! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants