Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bumping Serve Up to 9.2.0 Broke Calls to Serve's API #6598

Merged

Conversation

trvsysadmin
Copy link
Contributor

Follow Up on:

#6546

69125cc

Apologies in advance if some things are lacking, not super familiar with gatsby code base yet. I tested locally for v1 and it was fine.

In particular:

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jul 20, 2018

Deploy preview for using-postcss-sass failed.

Built with commit 5c88c9b

https://app.netlify.com/sites/using-postcss-sass/deploys/5b517139b13fb17317b6526b

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jul 20, 2018

Deploy preview for gatsbyjs failed.

Built with commit 5c88c9b

https://app.netlify.com/sites/gatsbyjs/deploys/5b517138b13fb17317b65263

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2018

Deploy preview for gatsbygram failed.

Built with commit 5c88c9b

https://app.netlify.com/sites/gatsbygram/deploys/5b517138b13fb17317b65265

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 20, 2018

Deploy preview for using-drupal ready!

Built with commit 5c88c9b

https://deploy-preview-6598--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor

Yeah, you can run gatsby serve --open. We should use something like https://www.npmjs.com/package/openurl to restore opening the URL after it's started.

@KyleAMathews
Copy link
Contributor

We don't need directory because serve defaults to using the current working directory as the base? E.g. you don't need an absolute path anymore?

@trvsysadmin
Copy link
Contributor Author

trvsysadmin commented Jul 20, 2018

Directory Question

Yes it seems to be so as far as this description: https://github.com/zeit/serve-handler#public-string

By default, the current working directory will be served. If you only want to serve a specific path, you can use this options to pass a custom directory to be served relative to the current working directory.

For example, if serving a Jekyll app, it would look like this:

{
  "public": "_site"
}

My test on v1 works with the public hardcoded string.

@trvsysadmin
Copy link
Contributor Author

trvsysadmin commented Jul 20, 2018

Dash Dash Open Option

  • I checked the current package.json and opn is already there
  • openurl dies for me via "GPU Process Fail" or something like that - I am on a ubuntu16 latest Chrome
  • opn has no such issue.

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KyleAMathews KyleAMathews merged commit ce9c3a8 into gatsbyjs:master Jul 20, 2018
@gatsbot
Copy link

gatsbot bot commented Jul 20, 2018

Holy buckets, @trvsysadmin — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

KyleAMathews pushed a commit that referenced this pull request Jul 20, 2018
* fix: Bumping Serve Up to 9.2.0 Broke Calls to Serve's API

Follow Up on 69125cc

* fix: Linting Errors

* fix: Linting Errors

* feat: Add Back OpenURL for gatsby serve --open option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants