-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bumping Serve Up to 9.2.0 Broke Calls to Serve's API #6598
fix: Bumping Serve Up to 9.2.0 Broke Calls to Serve's API #6598
Conversation
Deploy preview for using-postcss-sass failed. Built with commit 5c88c9b https://app.netlify.com/sites/using-postcss-sass/deploys/5b517139b13fb17317b6526b |
Deploy preview for gatsbyjs failed. Built with commit 5c88c9b https://app.netlify.com/sites/gatsbyjs/deploys/5b517138b13fb17317b65263 |
Deploy preview for gatsbygram failed. Built with commit 5c88c9b https://app.netlify.com/sites/gatsbygram/deploys/5b517138b13fb17317b65265 |
Deploy preview for using-drupal ready! Built with commit 5c88c9b |
Yeah, you can run |
We don't need |
Directory QuestionYes it seems to be so as far as this description: https://github.com/zeit/serve-handler#public-string
My test on v1 works with the |
Dash Dash Open Option
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Holy buckets, @trvsysadmin — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
* fix: Bumping Serve Up to 9.2.0 Broke Calls to Serve's API Follow Up on 69125cc * fix: Linting Errors * fix: Linting Errors * feat: Add Back OpenURL for gatsby serve --open option
Follow Up on:
#6546
69125cc
Apologies in advance if some things are lacking, not super familiar with gatsby code base yet. I tested locally for v1 and it was fine.
In particular:
directory
still needed? See https://github.com/zeit/serve-handler#public-stringopen
still needed?