Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cms build is compiled by webpack on a separate configuration #6391

Closed
wants to merge 1 commit into from
Closed

The cms build is compiled by webpack on a separate configuration #6391

wants to merge 1 commit into from

Conversation

emanueleperuffo
Copy link
Contributor

This tries to fix the netlify-cms plugin for v2 creating a separate webpack compilation

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit d3dddec

https://deploy-preview-6391--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit d3dddec

https://deploy-preview-6391--gatsbygram.netlify.com

@erquhart
Copy link
Contributor

Thanks for digging so far into this @emanueleperuffo! I didn't try the development build, but production builds are still pulling the main application styles in alongside the cms styles.

@emanueleperuffo
Copy link
Contributor Author

emanueleperuffo commented Jul 12, 2018

Really? That doesn't happen to my cms builds...

/cms.fd9333d1614f87e0d2b2.css here contains only code from netlify-cms.

<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8">
    <title>Content Manager</title>
  <link href="/cms.fd9333d1614f87e0d2b2.css" rel="stylesheet"></head>
  <body>
  <script type="text/javascript" src="/cms-938562dcd7f063f4c1d7.js"></script></body>
</html>

Or maybe you meant that in your main application you find css from netlify?
That doesn't happen to my builds as well...

@erquhart
Copy link
Contributor

It's a single bundle, but it includes the styles from the main application. This may depend on plugins, which has long been the problem with CMS styles in Gatsby. I'm using the Gatsby Netlify CMS starter to test against, which uses the sass plugin.

Sent with GitHawk

@m-allanson
Copy link
Contributor

@emanueleperuffo it looks like this can be closed now that #6356 has landed? Please-reopen if I've got it wrong.

@m-allanson m-allanson closed this Jul 20, 2018
@emanueleperuffo
Copy link
Contributor Author

Perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants