-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topics/regroup non static files #6346
Merged
m-allanson
merged 18 commits into
gatsbyjs:master
from
narative:topics/regroup-non-static-files
Jul 17, 2018
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4803d61
First try at cleaning up build output
brotzky e1b8be9
Adding flag to build, ordering pathPrefix correctly, and cleaned up s…
brotzky 77371b9
Removing the deletion of files as referenced by m-allanson and pieh
brotzky 59cf18a
Adding support for styles grouping
brotzky 366bd97
renaming output directories to js and css
brotzky 972fb6b
First try at cleaning up build output
brotzky 4042ae1
Adding flag to build, ordering pathPrefix correctly, and cleaned up s…
brotzky 695cb68
Removing the deletion of files as referenced by m-allanson and pieh
brotzky 699e5ca
Adding support for styles grouping
brotzky eed6616
renaming output directories to js and css
brotzky d8a8377
Merge branch 'topics/regroup-non-static-files' of github.com:narative…
brotzky 87f0ada
Removing config flag
brotzky cd834ab
Removing config flag logic from styles
brotzky 414ce25
Merge branch 'master' into topics/regroup-non-static-files
brotzky 41f80b6
Removing 'text/css' from CSS Link
brotzky ef334d2
Merge branch 'topics/regroup-non-static-files' of github.com:narative…
brotzky 6f1e987
Woops, adding back the CSS as I was testing locally and commited the …
brotzky f1ad758
Adding '../' to the relative static route similar to CSS
brotzky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-allanson This had to be treated the same way as the
../css/
case because of how there's only abuild-javascript
stage. #6346 (comment)Here are all the build stages:
I think in the future it could be a good idea to add discrete build stages for CSS (although CSS in JS makes this a question mark?) and static assets instead of relying on this current workaround.
Here's an example of the output folder of your example repository with this commit